This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG43fcfdb1d6a6: [IncludeCleaner][clangd] Mark umbrella headers
as users of private (authored by kadircet).
Repository:
rG LLVM Github Monorepo
kadircet updated this revision to Diff 507701.
kadircet added a comment.
- address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146406/new/
https://reviews.llvm.org/D146406
Files:
clang-tools-extra/clangd/IncludeCleaner.cpp
kadircet marked 2 inline comments as done.
kadircet added a comment.
thanks a lot for the review!
Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:100
+ // Check if main file is the public interface for a private header. If so
+ // we shouldn't diagnose
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:100
+ // Check if main file is the public interface for a private header. If so
+ // we
kadircet added inline comments.
Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:100
+ // Check if main file is the public interface for a private header. If so
+ // we shouldn't diagnose it as unused.
+ if (auto PHeader = PI->getPublic(I.Resolved);
hokein added inline comments.
Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:100
+ // Check if main file is the public interface for a private header. If so
+ // we shouldn't diagnose it as unused.
+ if (auto PHeader = PI->getPublic(I.Resolved);
kadircet created this revision.
kadircet added a reviewer: hokein.
Herald added a subscriber: arphaman.
Herald added a project: All.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added projects: clang, clang-tools-extra.
Private
