[PATCH] D146538: [analyzer] Fix crashing getSValFromInitListExpr for nested initlists

2023-03-23 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. This has been backported to clang-16.0.1 as 1172ed57d8234990b277281b3084969fcdb38602 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146

[PATCH] D146538: [analyzer] Fix crashing getSValFromInitListExpr for nested initlists

2023-03-22 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. Speaking of issue tracking, I think it would be much more valuable to our users if we had a proper release notes section for CSA. Right now it is so ad-hoc. That is also true for crash fixes and backports. Maybe we should put more emphasis on that part for the next majo

[PATCH] D146538: [analyzer] Fix crashing getSValFromInitListExpr for nested initlists

2023-03-22 Thread Balázs Benics via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG558b46fde2db: [analyzer] Fix crashing getSValFromInitListExpr for nested initlists (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1465

[PATCH] D146538: [analyzer] Fix crashing getSValFromInitListExpr for nested initlists

2023-03-21 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. In D146538#4210037 , @xazax.hun wrote: > Ugh :/ > > I wonder if we should also open tickets on GitHub to reduce the chance of > forgetting addressing the root cause for these. What do you think? Thanks for the quick review! I

[PATCH] D146538: [analyzer] Fix crashing getSValFromInitListExpr for nested initlists

2023-03-21 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Ugh :/ I wonder if we should also open tickets on GitHub to reduce the chance of forgetting addressing the root cause for these. What do you think? Repository: rG LLVM Github Monorep

[PATCH] D146538: [analyzer] Fix crashing getSValFromInitListExpr for nested initlists

2023-03-21 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. I think this one also deserves backporting to clang-16.0.1 @xazax.hun Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146538/new/ https://reviews.llvm.org/D146538 ___ cfe-commits

[PATCH] D146538: [analyzer] Fix crashing getSValFromInitListExpr for nested initlists

2023-03-21 Thread Balázs Benics via Phabricator via cfe-commits
steakhal created this revision. steakhal added reviewers: xazax.hun, NoQ. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a reviewer: Szelethus. Herald added a project: All. steak