[PATCH] D146552: [Clang][OpenMP] Enable device-mapped constexpr class members to not be optimized out

doru1004 closed this revision. doru1004 added a comment. Commit: 0eabf59528f3c3f64923900cae740d9f26c45ae8 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146552/new/ https://reviews.llvm.org/D146552 __

[PATCH] D146552: [Clang][OpenMP] Enable device-mapped constexpr class members to not be optimized out

jhuber6 accepted this revision. jhuber6 added a comment. LG, thanks. If you include `Fixes: ` in the commit message it'll automatically close it by the way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146552/new/ https://reviews.llvm.org/D146552

[PATCH] D146552: [Clang][OpenMP] Enable device-mapped constexpr class members to not be optimized out

doru1004 updated this revision to Diff 507485. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146552/new/ https://reviews.llvm.org/D146552 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_target_constexpr_codegen.cpp openmp/libomptarget/test/offloading/target_c

[PATCH] D146552: [Clang][OpenMP] Enable device-mapped constexpr class members to not be optimized out

doru1004 updated this revision to Diff 507483. doru1004 added a comment. Updated lit test to show variable added to compiler used vars. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146552/new/ https://reviews.llvm.org/D146552 Files: clang/lib/C

[PATCH] D146552: [Clang][OpenMP] Enable device-mapped constexpr class members to not be optimized out

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. This is as good as it gets until we rip out $ref. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146552/new/ https://reviews.llvm.org/D146552 ___

[PATCH] D146552: [Clang][OpenMP] Enable device-mapped constexpr class members to not be optimized out

doru1004 updated this revision to Diff 507190. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146552/new/ https://reviews.llvm.org/D146552 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_target_constexpr_codegen.cpp openmp/libomptarget/test/offloading/target_c

[PATCH] D146552: [Clang][OpenMP] Enable device-mapped constexpr class members to not be optimized out

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10384 // Do not create a "ref-variable" if the original is not also available // on the host. if (!OffloadEntriesInfoManager.hasDeviceGlobalVarEntryInfo(VarName)) -

[PATCH] D146552: [Clang][OpenMP] Enable device-mapped constexpr class members to not be optimized out

doru1004 updated this revision to Diff 507114. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146552/new/ https://reviews.llvm.org/D146552 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_target_constexpr_codegen.cpp openm

[PATCH] D146552: [Clang][OpenMP] Enable device-mapped constexpr class members to not be optimized out

doru1004 added a comment. In D146552#4210757 , @jhuber6 wrote: > We should have a clang test as well Agreed, working on one currently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146552/new/ https://rev

[PATCH] D146552: [Clang][OpenMP] Enable device-mapped constexpr class members to not be optimized out

jhuber6 added a comment. We should have a clang test as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146552/new/ https://reviews.llvm.org/D146552 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D146552: [Clang][OpenMP] Enable device-mapped constexpr class members to not be optimized out

doru1004 created this revision. doru1004 added reviewers: ronl, carlo.bertolli, jhuber6, jdoerfert, gregrodgers, dhruvachak. doru1004 added a project: OpenMP. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. doru1004 requested review of this revision. Herald adde