[PATCH] D146595: [clang] Add "transparent_stepping" attribute

augusto2112 updated this revision to Diff 511512. augusto2112 added a comment. Updated git commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146595/new/ https://reviews.llvm.org/D146595 Files: clang/include/clang/Basic/Attr.td

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

augusto2112 updated this revision to Diff 511511. augusto2112 marked 4 inline comments as done. augusto2112 added a comment. Updated to debug_trampoline, and addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146595/new/

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

aprantl added a comment. > Is there some place (bug, discourse thread, etc) where the broader direction > is discussed? I want to checkin on the design decisions/alternatives without > fragmenting this across multiple reviews/losing context/etc? No, I believe that all the relevant discussion

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

dblaikie added a comment. Is there some place (bug, discourse thread, etc) where the broader direction is discussed? I want to checkin on the design decisions/alternatives without fragmenting this across multiple reviews/losing context/etc? (specifically - this started out with the trampoline

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

aaron.ballman added a comment. In D146595#4237228 , @aprantl wrote: > I think `debug_trampoline` both captures the semantics and makes it clear > that this is related to debugging. I'd be fine with this, or `transparent_debug_stepping`, etc. Just

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

aprantl added a comment. I think `debug_trampoline` both captures the semantics and makes it clear that this is related to debugging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146595/new/ https://reviews.llvm.org/D146595

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

augusto2112 added a comment. In D146595#4235333 , @aprantl wrote: > I hope I'm not kicking off a long bike-shedding thread, but I would propose > to either call the attribute `transparent` to match the DWARF attribute name, > or if we want to be more

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

aprantl added a comment. I hope I'm not kicking off a long bike-shedding thread, but I would propose to either call the attribute `transparent` to match the DWARF attribute name, or if we want to be more descriptive, `debug_transparent`, or `transparentdebug` to fit better with other

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

augusto2112 added a comment. @aaron.ballman @dblaikie I've changed the patch to introduce a more general "transparent_stepping" attribute, which doesn't take in a string (similar to what David suggested), please take a look and let me know what you think. Repository: rG LLVM Github Monorepo