[PATCH] D146773: [-Wunsafe-buffer-usage] Make raw (ungrouped) warnings a bit more verbose.

NoQ added inline comments. Comment at: clang/test/SemaCXX/warn-unsafe-buffer-usage.cpp:256 - foo(f(p, &p, a, a)[1]); // expected-warning{{unsafe buffer access}} - // FIXME: expected note@-1{{in instantiation of function template specialization 'f' reque

[PATCH] D146773: [-Wunsafe-buffer-usage] Make raw (ungrouped) warnings a bit more verbose.

NoQ updated this revision to Diff 552560. NoQ added a comment. Rebase. Make warnings a bit more verbose than before. This plays nicely with our attempts to categorize unemitted fixits via `-mllvm -debug-only=SafeBuffers`, but this time it doesn't make sense to make the extra information debug-o

[PATCH] D146773: [-Wunsafe-buffer-usage] Make raw (ungrouped) warnings a bit more verbose.

NoQ added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11786 + "%select{" +"unsafe operation on raw pointer in expression|" +"unsafe arithmetic on raw pointer|" NoQ wrote: > malavikasamak wrote: > > NoQ wrote: > > > The f

[PATCH] D146773: [-Wunsafe-buffer-usage] Make raw (ungrouped) warnings a bit more verbose.

ziqingluo-90 accepted this revision. ziqingluo-90 added a comment. This revision is now accepted and ready to land. LGTM, Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146773/new/ https://reviews.llvm.org/D146773

[PATCH] D146773: [-Wunsafe-buffer-usage] Make raw (ungrouped) warnings a bit more verbose.

NoQ added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11786 + "%select{" +"unsafe operation on raw pointer in expression|" +"unsafe arithmetic on raw pointer|" malavikasamak wrote: > NoQ wrote: > > The first mode doesn't

[PATCH] D146773: [-Wunsafe-buffer-usage] Make raw (ungrouped) warnings a bit more verbose.

malavikasamak added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11786 + "%select{" +"unsafe operation on raw pointer in expression|" +"unsafe arithmetic on raw pointer|" NoQ wrote: > The first mode doesn't show up in any

[PATCH] D146773: [-Wunsafe-buffer-usage] Make raw (ungrouped) warnings a bit more verbose.

NoQ added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11786 + "%select{" +"unsafe operation on raw pointer in expression|" +"unsafe arithmetic on raw pointer|" The first mode doesn't show up in any tests and it's probabl

[PATCH] D146773: [-Wunsafe-buffer-usage] Make raw (ungrouped) warnings a bit more verbose.

NoQ created this revision. NoQ added reviewers: jkorous, t-rasmud, ziqingluo-90, malavikasamak, aaron.ballman, gribozavr, ymandel, sgatev. Herald added subscribers: steakhal, martong. Herald added a project: All. NoQ requested review of this revision. So far we didn't pay enough attention to them