mclow.lists closed this revision.
mclow.lists added a comment.
Herald added a subscriber: llvm-commits.
(Finally) committed this as revision 352087.
I cut out most of the random_shuffle_rand.pass.cpp test, because it relied on
C++11 features, and didn't work for C++03.
If you want to re-submit th
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
@gribozavr The tests have changed a bunch since this patch was created. I took
the liberty of re-merging the tests. You can find the updated patch here:
https://gist.github.com/EricWF/a69933b7
mclow.lists added inline comments.
Comment at:
test/std/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle.pass.cpp:35
@@ -30,1 +34,3 @@
}
+
+template
gribozavr wrote:
> gribozavr wrote:
> > mclow.lists wrote:
> > > This is not how I would re
gribozavr added inline comments.
Comment at:
test/std/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle.pass.cpp:35
@@ -30,1 +34,3 @@
}
+
+template
gribozavr wrote:
> mclow.lists wrote:
> > This is not how I would rewrite this test.
> > I wo
gribozavr added inline comments.
Comment at:
test/std/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle.pass.cpp:35
@@ -30,1 +34,3 @@
}
+
+template
mclow.lists wrote:
> This is not how I would rewrite this test.
> I would write a routine tha
mclow.lists added a comment.
Nice catch. The fix in `` is exactly right, but I think the tests
need more work.
Comment at:
test/std/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle.pass.cpp:35
@@ -30,1 +34,3 @@
}
+
+template
This is not
