This revision was automatically updated to reflect the committed changes.
Closed by commit rG0b103edf5b2c: [clangd] Fix a hover crash on unsigned 64bit
value (authored by zyounan).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146874/new/
nridge accepted this revision.
nridge added a comment.
This revision is now accepted and ready to land.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146874/new/
https://reviews.llvm.org/D146874
zyounan updated this revision to Diff 508401.
zyounan marked an inline comment as done.
zyounan added a comment.
Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146874/new/
https://reviews.llvm.org/D146874
Files:
zyounan marked 2 inline comments as done.
zyounan added a comment.
Thank you!
Comment at: clang-tools-extra/clangd/Hover.cpp:396
// -2=> 0xfffe
-// -2^32 => 0xfffe
+// -2^32 => 0x
static llvm::FormattedNumber printHex(const llvm::APSInt )
nridge added inline comments.
Comment at: clang-tools-extra/clangd/Hover.cpp:396
// -2=> 0xfffe
-// -2^32 => 0xfffe
+// -2^32 => 0x
static llvm::FormattedNumber printHex(const llvm::APSInt ) {
Just to make sure I'm not
zyounan updated this revision to Diff 508316.
zyounan added a comment.
Fix comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146874/new/
https://reviews.llvm.org/D146874
Files:
clang-tools-extra/clangd/Hover.cpp
zyounan created this revision.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
zyounan requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
This patch adapts to D140059
