v.g.vassilev added a comment.
Thanks! That was blocking our jupyter integration so I decided to go ahead here
since we already missed the clang17 train...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147319/new/
https://reviews.llvm.org/D147319
aaron.ballman added a comment.
LGTM :-)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147319/new/
https://reviews.llvm.org/D147319
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2c4620c1dadc: [clang-repl] Consider the scope spec in
template lookups for deduction guides. (authored by v.g.vassilev).
v.g.vassilev added a comment.
Let's rely on a post-commit review here.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147319/new/
https://reviews.llvm.org/D147319
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
v.g.vassilev updated this revision to Diff 520368.
v.g.vassilev added a comment.
clang-format
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147319/new/
https://reviews.llvm.org/D147319
Files:
clang/include/clang/Sema/Sema.h
clang/lib/Parse/ParseDecl.cpp
v.g.vassilev updated this revision to Diff 520322.
v.g.vassilev added a comment.
Rebase.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147319/new/
https://reviews.llvm.org/D147319
Files:
clang/include/clang/Sema/Sema.h
clang/lib/Parse/ParseDecl.cpp
v.g.vassilev added a comment.
ping.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147319/new/
https://reviews.llvm.org/D147319
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
v.g.vassilev created this revision.
v.g.vassilev added reviewers: aaron.ballman, rsmith.
Herald added a project: All.
v.g.vassilev requested review of this revision.
`isDeductionGuideName` looks up the underlying template and if the template
name is qualified we miss that qualification resulting