[PATCH] D147591: [clang][Interp] Handle CXXTemporaryObjectExprs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe45d1997686c: [clang][Interp] Handle CXXTemporaryObjectExprs (authored by tbaeder). Changed prior to commit:

[PATCH] D147591: [clang][Interp] Handle CXXTemporaryObjectExprs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LG pending test coverage being ready to land Comment at: clang/test/AST/Interp/records.cpp:317-318 { - auto T = Test(Arr, Pos); + Test(Arr,

[PATCH] D147591: [clang][Interp] Handle CXXTemporaryObjectExprs

tbaeder updated this revision to Diff 520361. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147591/new/ https://reviews.llvm.org/D147591 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/records.cpp Index:

[PATCH] D147591: [clang][Interp] Handle CXXTemporaryObjectExprs

tbaeder added inline comments. Comment at: clang/test/AST/Interp/records.cpp:317-318 { - auto T = Test(Arr, Pos); + Test(Arr, Pos); // End of scope, should destroy Test. } aaron.ballman wrote: > tbaeder wrote: > > aaron.ballman wrote:

[PATCH] D147591: [clang][Interp] Handle CXXTemporaryObjectExprs

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/records.cpp:317-318 { - auto T = Test(Arr, Pos); + Test(Arr, Pos); // End of scope, should destroy Test. } tbaeder wrote: > aaron.ballman wrote: > > tbaeder wrote:

[PATCH] D147591: [clang][Interp] Handle CXXTemporaryObjectExprs

tbaeder added inline comments. Comment at: clang/test/AST/Interp/records.cpp:317-318 { - auto T = Test(Arr, Pos); + Test(Arr, Pos); // End of scope, should destroy Test. } aaron.ballman wrote: > tbaeder wrote: > > aaron.ballman wrote:

[PATCH] D147591: [clang][Interp] Handle CXXTemporaryObjectExprs

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/records.cpp:317-318 { - auto T = Test(Arr, Pos); + Test(Arr, Pos); // End of scope, should destroy Test. } tbaeder wrote: > aaron.ballman wrote: > > Nit: nothing

[PATCH] D147591: [clang][Interp] Handle CXXTemporaryObjectExprs

tbaeder added inline comments. Comment at: clang/test/AST/Interp/records.cpp:317-318 { - auto T = Test(Arr, Pos); + Test(Arr, Pos); // End of scope, should destroy Test. } aaron.ballman wrote: > Nit: nothing actually tests that this

[PATCH] D147591: [clang][Interp] Handle CXXTemporaryObjectExprs

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/records.cpp:317-318 { - auto T = Test(Arr, Pos); + Test(Arr, Pos); // End of scope, should destroy Test. } Nit: nothing actually tests that this object is destroyed

[PATCH] D147591: [clang][Interp] Handle CXXTemporaryObjectExprs

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147591/new/ https://reviews.llvm.org/D147591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147591: [clang][Interp] Handle CXXTemporaryObjectExprs

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147591/new/ https://reviews.llvm.org/D147591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147591: [clang][Interp] Handle CXXTemporaryObjectExprs

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a CXXConstructExpr, so create a local