This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG72777dc000ac: [clang-tidy] avoid colon in namespace cause
false positve (authored by HerrCai0907).
Repository:
rG LLVM Github Monorepo
CHANGES SI
HerrCai0907 updated this revision to Diff 512116.
HerrCai0907 added a comment.
remove debug log
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147893/new/
https://reviews.llvm.org/D147893
Files:
clang-tools-extra/clang-tidy/modernize/ConcatNested
PiotrZSL accepted this revision.
PiotrZSL added a comment.
This revision is now accepted and ready to land.
Except above llvm:errs, looks good to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147893/new/
https://reviews.llvm.org/D147893
__
PiotrZSL added inline comments.
Comment at:
clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:175
+ llvm::errs() << Namespaces.size() << " " << ND.getName() << " clear\n";
Namespaces.clear();
debug log...
Repository:
rG LLVM Github
HerrCai0907 created this revision.
HerrCai0907 added a reviewer: PiotrZSL.
Herald added subscribers: carlosgalvezp, xazax.hun.
Herald added a reviewer: njames93.
Herald added a project: All.
HerrCai0907 requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a sub
