[PATCH] D147894: [clang-format] SortIncludes documentation: remove contradiction in its description

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Yes I didn’t see them repeated below CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147894/new/ https://reviews.llvm.org/D147894 __

[PATCH] D147894: [clang-format] SortIncludes documentation: remove contradiction in its description

michael-g-matthews added a comment. I am also a little confused by what you mean @MyDeveloperDay. The options that were removed contained incorrect documentation (listing ASCIIbetical as CaseInsensitive). The enum documentation immediately after was however correct, so the documentation was sel

[PATCH] D147894: [clang-format] SortIncludes documentation: remove contradiction in its description

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. In D147894#4254941 , @MyDeveloperDay wrote: > Sorry I don’t get how this change helps. Removing the option values does make > it clearer IMHO What options? CHANGES SINCE L

[PATCH] D147894: [clang-format] SortIncludes documentation: remove contradiction in its description

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Sorry I don’t get how this change helps. Removing the option values does make it clearer IMHO CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147894/new/ http

[PATCH] D147894: [clang-format] SortIncludes documentation: remove contradiction in its description

michael-g-matthews updated this revision to Diff 512042. michael-g-matthews added a comment. Amended commit to include change to `clang/include/clang/Format/Format.h` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147894/new/ https://reviews.llvm.org/D147894 Files: clang/docs/ClangFor

[PATCH] D147894: [clang-format] SortIncludes documentation: remove contradiction in its description

michael-g-matthews created this revision. michael-g-matthews added reviewers: MyDeveloperDay, owenpan. michael-g-matthews added a project: clang-format. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks. Herald added a comm