This revision was automatically updated to reflect the committed changes.
Closed by commit rGd9826433f31c: [clang] Implement CWG 2397 (authored by
zyounan).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147909/new/
https://reviews.llvm.org/D147909
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: clang/test/CXX/dcl.decl/dcl.meaning/dcl.array/p1-cxx0x.cpp:5
int b[5];
- auto a[5] = b; // expected-error{{'a' declared as array of 'auto'
zyounan added a comment.
Thank you for the suggestion and I've updated my patch. :)
Comment at: clang/test/CXX/dcl.decl/dcl.meaning/dcl.array/cwg2397.cpp:11
+}
+
+void g() {
aaron.ballman wrote:
> I think it'd be good to also show a constexpr test, like:
> ```
zyounan updated this revision to Diff 512656.
zyounan marked an inline comment as done.
zyounan added a comment.
Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147909/new/
https://reviews.llvm.org/D147909
Files:
clang/docs/Releas
Endill added a comment.
Agree, this test clearly belongs to `clang/test/CXX/drs/dr23xx.cpp`.
There is a `clang/www/make_cxx_dr_status` script to update cxx_dr_status page,
so you don't have to edit it manually.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.l
aaron.ballman added a reviewer: clang-language-wg.
aaron.ballman added a comment.
The changes need a release note, but also this should have changes to
`clang/test/CXX/drs/dr23xx.cpp` with the proper dr markings and update
`clang/www/cxx_dr_status.html`.
Comment at: clang/tes
shafik added a comment.
This looks good but I will let at least one more reviewer take a look
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147909/new/
https://reviews.llvm.org/D147909
___
cfe-commits ma
zyounan created this revision.
Herald added a project: All.
zyounan added a comment.
zyounan added reviewers: aaron.ballman, erichkeane, rsmith.
zyounan published this revision for review.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Note GCC had implemented such feature
