[PATCH] D147935: [RISCV] Add SiFive extension support

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd5c4cb7e0ae: [RISCV] Add SiFive extension support (authored by kito-cheng, committed by 4vtomat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147935/new/

[PATCH] D147935: [RISCV] Add SiFive extension support

asb accepted this revision. asb added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147935/new/ https://reviews.llvm.org/D147935 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D147935: [RISCV] Add SiFive extension support

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147935/new/ https://reviews.llvm.org/D147935 ___

[PATCH] D147935: [RISCV] Add SiFive extension support

4vtomat updated this revision to Diff 513223. 4vtomat added a comment. Resolved Alex's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147935/new/ https://reviews.llvm.org/D147935 Files: clang/include/clang/Support/RISCVVIntrinsicUtils.h

[PATCH] D147935: [RISCV] Add SiFive extension support

4vtomat added a comment. In D147935#4259687 , @craig.topper wrote: > Is there a different patch with the .td for these intrinsics? Yes, it's in this patch: D148223 Comment at: clang/include/clang/Su

[PATCH] D147935: [RISCV] Add SiFive extension support

craig.topper added a comment. Is there a different patch with the .td for these intrinsics? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147935/new/ https://reviews.llvm.org/D147935 ___ cfe-commits mail

[PATCH] D147935: [RISCV] Add SiFive extension support

asb added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:465 RVV_REQ_FullMultiply = 1 << 1, + RVV_REQ_xsfvcp = 1 << 2, Nit: It would better match the surrounding capitalisation to call this RVV_REQ_Xsfvcp Repository: rG

[PATCH] D147935: [RISCV] Add SiFive extension support

4vtomat created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, ni