This revision was automatically updated to reflect the committed changes.
Closed by commit rGed365f464a0a: [clangd] Use FileEntryRef for canonicalizing
filepaths. (authored by usaxena95).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148213/new/
htt
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148213/new/
https://reviews.llvm.org/D148213
usaxena95 updated this revision to Diff 513219.
usaxena95 marked 6 inline comments as done.
usaxena95 added a comment.
Addressed comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148213/new/
https://reviews.llvm.org/D148213
Files:
clang-to
kadircet added a comment.
we've got one more reference to `getCanonicalPath` in
`clang-tools-extra/clangd/IncludeCleaner.cpp:320`, i guess the best way is just
calling `getLastRef` on the FileEntry*
Comment at: clang-tools-extra/clangd/SourceCode.cpp:518
usaxena95 updated this revision to Diff 513168.
usaxena95 added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148213/new/
https://reviews.llvm.org/D148213
Files:
clang-tools-extra/clangd/Diagnostics.cpp
clang-tools-extra/clan
usaxena95 updated this revision to Diff 513165.
usaxena95 added a comment.
More refactorings.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148213/new/
https://reviews.llvm.org/D148213
Files:
clang-tools-extra/clangd/Diagnostics.cpp
clang-tool
usaxena95 created this revision.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
usaxena95 requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Repository:
rG LLVM Github Monorepo
