[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

kito-cheng accepted this revision. kito-cheng added a comment. LGTM, but IMO the title should still contain [RISCV][clang] Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

4vtomat updated this revision to Diff 516598. 4vtomat added a comment. Removed unnecessary comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223 Files:

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

4vtomat updated this revision to Diff 516596. 4vtomat added a comment. Resolved Craig's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223 Files: clang/include/clang/Basic/riscv_sifive_vector.td

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_sifive_vector.td:46 + +multiclass RVVVCIXBuiltinSet range, string prototype, + list intrinsic_types, bit EncodeVtype, We might consider breaking this

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

4vtomat updated this revision to Diff 514821. 4vtomat added a comment. Resolved Craig's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223 Files: clang/include/clang/Basic/riscv_sifive_vector.td

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_sifive_vector.td:41 + if !find(prototype, "0") then { + def : VCIXBuiltinSet; + } Indent Comment at: clang/include/clang/Basic/riscv_sifive_vector.td:64 +

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

4vtomat updated this revision to Diff 514812. 4vtomat added a comment. Rename riscv_sifive_vcix.td to riscv_sifive_vector.td Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223 Files:

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

4vtomat updated this revision to Diff 514810. 4vtomat added a comment. Resolved Kito's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223 Files: clang/include/clang/Basic/riscv_sifive_vcix.td

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

4vtomat updated this revision to Diff 513464. 4vtomat added a comment. Herald added a subscriber: arphaman. Resolved Craig's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223 Files:

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2422 + // Log2LMUL to zero. Otherwise the RISCVVEmitter will expand + // lots of redunant intrinsic but have same names. + let Log2LMUL = [0] in

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

craig.topper added a comment. We need SemaChecking.cpp code to check the range of the constant arguments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223 ___

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

4vtomat created this revision. Herald added subscribers: luke, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb. Herald added a project: