[PATCH] D148423: [clangd] Support define outline tweak for non cross file edits

2023-05-04 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148423/new/ https://reviews.llvm.org/D148423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D148423: [clangd] Support define outline tweak for non cross file edits

2023-04-15 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 513911. njames93 added a comment. - Clang format changes - Update apply logic to not query the FS when its not a cross file edit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148423/new/ https://reviews.llvm.o

[PATCH] D148423: [clangd] Support define outline tweak for non cross file edits

2023-04-15 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. Theres definitely scope to improve this in follow ups. We could support this for template methods and classes template struct A { void [[Foo]]() {} template void [[Bar]]() {} }; // Both ranges transformed to template struct A { void Foo(); te

[PATCH] D148423: [clangd] Support define outline tweak for non cross file edits

2023-04-15 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: kadircet, sammccall, nridge. Herald added a subscriber: arphaman. Herald added a project: All. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-ext