[PATCH] D148425: [clang-repl] Correctly disambiguate dtor declarations from statements

2023-05-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:91 return true; - case tok::annot_cxxscope: // Check if this is a dtor. -if (NextToken().is(tok::tilde)) v.g.vassilev wrote: > aaron.ballman wrote: > > Are y

[PATCH] D148425: [clang-repl] Correctly disambiguate dtor declarations from statements

2023-05-02 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev marked an inline comment as done. v.g.vassilev added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:91 return true; - case tok::annot_cxxscope: // Check if this is a dtor. -if (NextToken().is(tok::tilde)) aaron.

[PATCH] D148425: [clang-repl] Correctly disambiguate dtor declarations from statements

2023-05-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:91 return true; - case tok::annot_cxxscope: // Check if this is a dtor. -if (NextToken().is(tok::tilde)) Are you sure you can remove this? Wouldn't this be u

[PATCH] D148425: [clang-repl] Correctly disambiguate dtor declarations from statements

2023-04-30 Thread Vassil Vassilev via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG5a9abe846617: [clang-repl] Correctly disambiguate dtor declarations from statements. (authored by v.g.vassilev). Herald ad

[PATCH] D148425: [clang-repl] Correctly disambiguate dtor declarations from statements

2023-04-30 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added a comment. Let's rely on a post-commit review here. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148425/new/ https://reviews.llvm.org/D148425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148425: [clang-repl] Correctly disambiguate dtor declarations from statements

2023-04-15 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, aaron.ballman. Herald added a project: All. v.g.vassilev requested review of this revision. Repository: rC Clang https://reviews.llvm.org/D148425 Files: clang/lib/Parse/ParseTentative.cpp clang/test/Interpreter/disam