[PATCH] D148433: [clang] Add tests for DRs about complete-class context

2023-04-17 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill updated this revision to Diff 514353. Endill added a comment. Weaken the FIXME wording per Shafik's suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148433/new/ https://reviews.llvm.org/D148433 Files: clang/test/CXX/drs/dr13xx.cpp

[PATCH] D148433: [clang] Add tests for DRs about complete-class context

2023-04-17 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:42 +namespace dr2335 { // dr2335: no drafting +// FIXME: all of the examples are well-formed. Endill wrote: > aaron.ballman wrote: > > Endill wrote: > > > shafik wrote: > > > > My comment o

[PATCH] D148433: [clang] Add tests for DRs about complete-class context

2023-04-17 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:42 +namespace dr2335 { // dr2335: no drafting +// FIXME: all of the examples are well-formed. aaron.ballman wrote: > Endill wrote: > > shafik wrote: > > > My comment on 1890 applies here as

[PATCH] D148433: [clang] Add tests for DRs about complete-class context

2023-04-17 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:42 +namespace dr2335 { // dr2335: no drafting +// FIXME: all of the examples are well-formed. Endill wrote: > shafik wrote: > > My comment on 1890 applies here as well. > > > > CC @

[PATCH] D148433: [clang] Add tests for DRs about complete-class context

2023-04-17 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:42 +namespace dr2335 { // dr2335: no drafting +// FIXME: all of the examples are well-formed. shafik wrote: > My comment on 1890 applies here as well. > > CC @rsmith @aaron.ballman how sho

[PATCH] D148433: [clang] Add tests for DRs about complete-class context

2023-04-17 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: clang/test/CXX/drs/dr16xx.cpp:46 +namespace dr1626 { // dr1626: no open +// FIXME: all of the examples are well-formed +#if __cplusplus >= 201103L Since this is still open, should we be expressing an opinion on whether th

[PATCH] D148433: [clang] Add tests for DRs about complete-class context

2023-04-17 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added subscribers: aaron.ballman, rsmith. shafik added inline comments. Comment at: clang/test/CXX/drs/dr18xx.cpp:139 +namespace dr1890 { // dr1890: no drafting +// FIXME: all the examples are well-formed. So this is still in drafting: https://www.open-

[PATCH] D148433: [clang] Add tests for DRs about complete-class context

2023-04-15 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill created this revision. Endill added reviewers: erichkeane, shafik. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : The intent for CWG2335 (contra those of the olde