junaire marked an inline comment as done.
junaire added inline comments.
Comment at: clang/lib/Interpreter/IncrementalExecutor.cpp:88
return Sym.takeError();
- return Sym->getValue();
+ return llvm::orc::ExecutorAddr(Sym->getValue());
}
sgraenitz wrote:
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
junaire marked an inline comment as done.
Closed by commit rGfe1f34453d7e: [clang-repl] JITTargetAddress --
ExecutorAddr, NFC (authored by junaire).
Changed prior to
sgraenitz accepted this revision.
sgraenitz added a comment.
This revision is now accepted and ready to land.
Thanks. Maybe you can fix this one detail and add a description like "Most of
Orc and JITLink are movinng away from JITTargetAddress and use ExecutorAddr
instead"? Otherwise LGTM.
junaire updated this revision to Diff 513924.
junaire added a comment.
Avoid unnecessary changes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148434/new/
https://reviews.llvm.org/D148434
Files:
clang/include/clang/Interpreter/Interpreter.h
junaire created this revision.
Herald added a project: All.
junaire requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Signed-off-by: Jun Zhang
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D148434
Files:
