[PATCH] D148437: [clang-format] Dont interpret variable named interface as keyword for C++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9db2a0454815: [clang-format] Dont interpret variable named interface as keyword for C++ (authored by sousajo, committed by owenpan). Repository: r

[PATCH] D148437: [clang-format] Dont interpret variable named interface as keyword for C++

sousajo added a comment. cannot reproduce the build failure locally. if this looks fine can someone land it for me? or should we wait until we have a green build after rebase? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148437/new/ https://reviews.llvm.org/D148437 __

[PATCH] D148437: [clang-format] Dont interpret variable named interface as keyword for C++

sousajo updated this revision to Diff 513969. sousajo added a comment. - rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148437/new/ https://reviews.llvm.org/D148437 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp Index: clang/unittests

[PATCH] D148437: [clang-format] Dont interpret variable named interface as keyword for C++

sousajo updated this revision to Diff 513946. sousajo added a comment. - inline string to be checked CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148437/new/ https://reviews.llvm.org/D148437 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp In

[PATCH] D148437: [clang-format] Dont interpret variable named interface as keyword for C++

sousajo updated this revision to Diff 513945. sousajo added a comment. - removed `FormatStyle Style = getLLVMStyle();` as llvm is the default style CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148437/new/ https://reviews.llvm.org/D148437 Files: clang/lib/Format/UnwrappedLineParser.c

[PATCH] D148437: [clang-format] Dont interpret variable named interface as keyword for C++

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25432 +TEST_F(FormatTest, InterfaceAsFieldName) { + FormatStyle Style = getLLVMStyle(); Comment at: clang/unittests/Format/FormatTest.cpp:25433-25439 + Format

[PATCH] D148437: [clang-format] Dont interpret variable named interface as keyword for C++

sousajo added a comment. As I dont have commit access if someone can land It for me: Jorge Pinto Sousa CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148437/new/ https://reviews.llvm.org/D148437 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D148437: [clang-format] Dont interpret variable named interface as keyword for C++

sousajo created this revision. sousajo added a reviewer: MyDeveloperDay. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan. sousajo requested review of this revision. Fixes: https://github.com/llvm/l