This revision was automatically updated to reflect the committed changes.
Closed by commit rGda836b36bc35: [clang][Interp] Track frame depth (authored by
tbaeder).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148614/new/
https://reviews.llvm.org/D1
tbaeder updated this revision to Diff 526565.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148614/new/
https://reviews.llvm.org/D148614
Files:
clang/lib/AST/Interp/Interp.cpp
clang/lib/AST/Interp/Interp.h
clang/lib/AST/Interp/InterpFrame.cpp
clang/lib/AST/Interp/InterpFrame.h
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/Interp.cpp:345-352
+ if ((S.Current->getDepth() + 1) > S.getLangOpts().ConstexprCallDepth) {
+S.FFDiag(S.Current->getSource(OpPC),
+ diag::note_constexpr_depth_limit_exceeded)
+<< S.getLangOp
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, though I would appreciate adding the other test case from my comments
since it's interesting behavior.
Comment at: clang/lib/AST/Interp/Interp.cpp:345-35
aaron.ballman added inline comments.
Comment at: clang/lib/AST/Interp/Interp.cpp:345-352
+ if ((S.Current->getDepth() + 1) > S.getLangOpts().ConstexprCallDepth) {
+S.FFDiag(S.Current->getSource(OpPC),
+ diag::note_constexpr_depth_limit_exceeded)
+<< S.get
tbaeder added a comment.
Ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148614/new/
https://reviews.llvm.org/D148614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
shafik added a comment.
The changes make sense, I am sure about any trade-offs of doing the checking
during the call Vs doing at return.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148614/new/
https://reviews.llvm.org/D148614
___
cfe-commi
tbaeder added a comment.
Ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148614/new/
https://reviews.llvm.org/D148614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaeder updated this revision to Diff 514826.
tbaeder added a comment.
Move things around a bit and add some `+ 1`s to get matching diagnostic output
with the current interpreter.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148614/new/
https://reviews.llvm.org/D148614
Files:
clang
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, tahonermann, erichkeane, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
There was already //some// form of this, but it was
10 matches
Mail list logo