[PATCH] D148783: [clangd] Add support TextDocumentEdit.

DavidSpickett added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148783/new/ https://reviews.llvm.org/D148783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148783: [clangd] Add support TextDocumentEdit.

hokein added a comment. should be fixed in https://github.com/llvm/llvm-project/commit/4294619b4cdfed49502dcebc7efd5f044e587267. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148783/new/ https://reviews.llvm.org/D148783

[PATCH] D148783: [clangd] Add support TextDocumentEdit.

hokein added a comment. In D148783#4298398 , @DavidSpickett wrote: > Hi, these tests are failing on our (Linaro's) Windows on Arm buildbot. First > appearance here https://lab.llvm.org/buildbot/#/builders/65/builds/9346 > > Still failing as of a few

[PATCH] D148783: [clangd] Add support TextDocumentEdit.

DavidSpickett added a comment. Hi, these tests are failing on our (Linaro's) Windows on Arm buildbot. First appearance here https://lab.llvm.org/buildbot/#/builders/65/builds/9346 Still failing as of a few hours ago https://lab.llvm.org/buildbot/#/builders/65/builds/9360 (maybe you have fixed

[PATCH] D148783: [clangd] Add support TextDocumentEdit.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67e02b282b70: [clangd] Add support TextDocumentEdit. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148783: [clangd] Add support TextDocumentEdit.

hokein updated this revision to Diff 516734. hokein marked an inline comment as done. hokein added a comment. update and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148783/new/ https://reviews.llvm.org/D148783 Files:

[PATCH] D148783: [clangd] Add support TextDocumentEdit.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1694 -std::vector ClangdLSPServer::getFixes(llvm::StringRef File, -

[PATCH] D148783: [clangd] Add support TextDocumentEdit.

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1746 + + if (DiagOpts.EmbedFixesInDiagnostics && !CodeActions.empty()) { + Diag.codeActions.emplace(CodeActions); kadircet wrote: > we

[PATCH] D148783: [clangd] Add support TextDocumentEdit.

hokein updated this revision to Diff 516702. hokein added a comment. address review comments, added one more test for command code-actions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148783/new/ https://reviews.llvm.org/D148783 Files:

[PATCH] D148783: [clangd] Add support TextDocumentEdit.

kadircet added a comment. In D148783#4286652 , @hokein wrote: >> can you also have a version of the >> clang-tools-extra/clangd/test/fixits-command.test with documentChanges >> support? it's unlikely to have clients in that configuration but i believe

[PATCH] D148783: [clangd] Add support TextDocumentEdit.

hokein added a comment. > can you also have a version of the > clang-tools-extra/clangd/test/fixits-command.test with documentChanges > support? it's unlikely to have clients in that configuration but i believe > the deserialization issue i mentioned above would be discoverable by such a >

[PATCH] D148783: [clangd] Add support TextDocumentEdit.

hokein updated this revision to Diff 515671. hokein marked 2 inline comments as done. hokein added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148783/new/ https://reviews.llvm.org/D148783 Files:

[PATCH] D148783: [clangd] Add support TextDocumentEdit.

kadircet added a comment. can you also have a version of the clang-tools-extra/clangd/test/fixits-command.test with `documentChanges` support? it's unlikely to have clients in that configuration but i believe the deserialization issue i mentioned above would be discoverable by such a test.

[PATCH] D148783: [clangd] Add support TextDocumentEdit.

hokein updated this revision to Diff 515230. hokein added a comment. add missing test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148783/new/ https://reviews.llvm.org/D148783 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D148783: [clangd] Add support TextDocumentEdit.

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1722 [&](clangd::Diagnostic Diag, llvm::ArrayRef Fixes) { + if (DiagOpts.EmbedFixesInDiagnostics && !Fixes.empty()) { +

[PATCH] D148783: [clangd] Add support TextDocumentEdit.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is an initial patch to add