[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

hans added a comment. This broke the tests on Mac, see e.g. https://green.lab.llvm.org/green/job/clang-stage1-RA/34396/consoleFull (or http://crbug.com/1447928) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148785/new/ https://reviews.llvm.org/D1

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46f366494f3c: -fsanitize=function: use type hashes instead of RTTI objects (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

MaskRay added inline comments. Comment at: clang/test/CodeGenCXX/catch-undef-behavior.cpp:408 // RTTI pointer check + // CHECK: [[CalleeTypeHashPtr:%.+]] = getelementptr <{ i32, i32 }>, <{ i32, i32 }>* [[PTR]], i32 -1, i32 1 peter.smith wrote: > MaskRay wr

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

MaskRay updated this revision to Diff 523984. MaskRay marked 2 inline comments as done. MaskRay added a comment. fix a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148785/new/ https://reviews.llvm.org/D148785 Files: clang/docs/Undefined

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

peter.smith added inline comments. Comment at: clang/test/CodeGenCXX/catch-undef-behavior.cpp:408 // RTTI pointer check + // CHECK: [[CalleeTypeHashPtr:%.+]] = getelementptr <{ i32, i32 }>, <{ i32, i32 }>* [[PTR]], i32 -1, i32 1 MaskRay wrote: > peter.smit

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

MaskRay added inline comments. Comment at: llvm/test/CodeGen/AArch64/patchable-function-entry-bti.ll:92 ; CHECK-NEXT: .Ltmp{{.*}}: ; CHECK-NEXT: nop ; CHECK-NEXT: .word 3238382334 // 0xc105cafe MaskRay wrote: > peter.smith wrote: > > samitolvanen wrote:

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

MaskRay marked 2 inline comments as done. MaskRay added inline comments. Comment at: clang/test/CodeGenCXX/catch-undef-behavior.cpp:408 // RTTI pointer check + // CHECK: [[CalleeTypeHashPtr:%.+]] = getelementptr <{ i32, i32 }>, <{ i32, i32 }>* [[PTR]], i32 -1, i32 1 --

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

MaskRay added inline comments. Comment at: llvm/test/CodeGen/AArch64/patchable-function-entry-bti.ll:92 ; CHECK-NEXT: .Ltmp{{.*}}: ; CHECK-NEXT: nop ; CHECK-NEXT: .word 3238382334 // 0xc105cafe peter.smith wrote: > samitolvanen wrote: > > peter.smith wr

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

peter.smith added inline comments. Comment at: llvm/test/CodeGen/AArch64/patchable-function-entry-bti.ll:92 ; CHECK-NEXT: .Ltmp{{.*}}: ; CHECK-NEXT: nop ; CHECK-NEXT: .word 3238382334 // 0xc105cafe samitolvanen wrote: > peter.smith wrote: > > Assuming t

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

samitolvanen accepted this revision. samitolvanen added a comment. This revision is now accepted and ready to land. Looks good to me, but maybe worth waiting for someone more familiar with compiler-rt to take a look as well. Comment at: llvm/test/CodeGen/AArch64/patchable-func

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

MaskRay added a comment. In D148785#4348053 , @vitalybuka wrote: > Is possible to split the patch into smaller ones? The Clang CodeGen side needs to match `llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp` and `compiler-rt/lib/ubsan`, so no, I think this is

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

vitalybuka added a comment. Is possible to split the patch into smaller ones? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148785/new/ https://reviews.llvm.org/D148785 ___ cfe-commits mailing list cfe-c

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

MaskRay updated this revision to Diff 522286. MaskRay marked 2 inline comments as done. MaskRay added a comment. rename a variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148785/new/ https://reviews.llvm.org/D148785 Files: clang/docs/Undef

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

MaskRay marked 2 inline comments as done. MaskRay added a comment. In D148785#4343112 , @peter.smith wrote: > Should `HANDLER(__ubsan_handle_function_type_mismatch,"function")` be added > to ubsan_minimal_runtime if this is supported in the minimal runt

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

peter.smith added a comment. Should `HANDLER(__ubsan_handle_function_type_mismatch,"function")` be added to ubsan_minimal_runtime if this is supported in the minimal runtime? Comment at: clang/lib/CodeGen/CGExpr.cpp:5382 + getPointerAlign()); llvm::Value *Calle

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

MaskRay updated this revision to Diff 515243. MaskRay added a comment. Herald added a subscriber: pengfei. update llvm/test/CodeGen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148785/new/ https://reviews.llvm.org/D148785 Files: clang/docs/Unde

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

MaskRay created this revision. MaskRay added reviewers: Sanitizers, pcc, peter.smith, sberg, samitolvanen. Herald added subscribers: Enna1, hiraditya. Herald added a project: All. MaskRay requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: ll