This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9bb28a18d962: [C2x] Update 'nullptr'
implementation based on CD comments (authored by aaron.ballman).
Repository:
rG LLVM Github Monorepo
CHANGES
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148800/new/
https://reviews.llvm.org/D148800
___
cfe-commits mailing list
cfe-commi
aaron.ballman updated this revision to Diff 519102.
aaron.ballman added a comment.
Updated based on review feedback:
- Changed CK_Noop to CK_NullToPointer to model the same as in C++
- Added codegen tests
- Added a constant expression test
- Fixed some comments in the test file
CHANGES SINCE LA
efriedma added inline comments.
Comment at: clang/lib/Sema/SemaExpr.cpp:10087
+// a conversion.
+Kind = CK_NoOp;
+return Compatible;
I'd like to see testcases for:
- Codegen (LLVM IR emission)
- Constant evaluation. (Is a cast like this allowed in a
aaron.ballman added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148800/new/
https://reviews.llvm.org/D148800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
aaron.ballman created this revision.
aaron.ballman added reviewers: rsmith, clang-language-wg, efriedma, rjmccall,
erichkeane.
Herald added a project: All.
aaron.ballman requested review of this revision.
Herald added a project: clang.
We filed some CD ballot comments which WG14 considered during
