[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Manna marked an inline comment as done. Closed by commit rGff4d2207db00: [NFC][clang] Fix static analyzer concerns (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

Manna marked an inline comment as done. Manna added inline comments. Comment at: clang/lib/Lex/Pragma.cpp:1110 Module *M = nullptr; - for (auto IIAndLoc : ModuleName) { + for (const auto &IIAndLoc : ModuleName) { M = MM.lookupModuleQualified(IIAndLoc.fir

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

Manna updated this revision to Diff 515729. Manna edited the summary of this revision. Manna added a comment. I have addressed @erichkeane's review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148812/new/ https://reviews.llvm.org/D148812 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

erichkeane added a comment. Still had this convo which wasn't resolved. Comment at: clang/lib/Lex/Pragma.cpp:1110 Module *M = nullptr; - for (auto IIAndLoc : ModuleName) { + for (const auto &IIAndLoc : ModuleName) { M = MM.lookupModuleQualified(IIAndLo

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

Manna marked an inline comment as done. Manna added a comment. @erichkeane do you have any more concerns? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148812/new/ https://reviews.llvm.org/D148812 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

Manna marked an inline comment as done. Manna added a comment. Thank you @tahonermann and @erichkeane for reviews and feedback. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:4262 // will be using. - for (auto I : Attrs) { + for (const auto &I : Attrs) { const

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Thanks, Soumi! Looks good to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148812/new/ https://reviews.llvm.org/D148812 ___

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

Manna updated this revision to Diff 515494. Manna marked an inline comment as done and an inline comment as not done. Manna edited the summary of this revision. Manna added a comment. I have removed the case involving the `Policy` class CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14881

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

tahonermann added a comment. With the exception of the case involving the `Policy` class, these changes all look fine to me. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:562 if (UnMaskedPolicyScheme != PolicyScheme::SchemeNone) - for (auto P : Supported

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

erichkeane added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:8206 - for (auto B : CXXRD->bases()) + for (const auto &B : CXXRD->bases()) if (hasTemplateSpecializationInEncodedString(B.getType().getTypePtr(), Manna wrote: > CXXBaseSpecifier

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

Manna added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:8206 - for (auto B : CXXRD->bases()) + for (const auto &B : CXXRD->bases()) if (hasTemplateSpecializationInEncodedString(B.getType().getTypePtr(), CXXBaseSpecifier is less in size, but

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

Manna created this revision. Manna added a reviewer: tahonermann. Herald added subscribers: luke, manas, frasercrmck, ASDenysPetrov, luismarques, apazos, sameer.abuasal, s.egerton, Jim, dkrupp, donat.nagy, jocewei, Szelethus, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, a.sidorin, edward-jon