[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

delcypher added a comment. @ahatanak Thanks for working on this. I think that annotating these particular tests so that's clear that they are supposed to crash (and therefore symbolication is of no use) is a good change. If we want to make a more global change for tests I think that should be

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

dblaikie added a comment. In D148851#4357360 , @arsenm wrote: > I also think we need to revert or disable > https://github.com/llvm/llvm-project/commit/cead4eceb01b935fae07bf4a7e91911b344d2fec > > The symbolizer is unusably slow with it I believe that

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

dblaikie added a comment. In D148851#4285705 , @dblaikie wrote: >> I think we probably should add LLVM_DISABLE_SYMBOLIZATION=1 to the lit >> level, not in individual tests. > > Though I'm not sure how to do that in a way that it doesn't apply to test

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

arsenm added a comment. I also think we need to revert or disable https://github.com/llvm/llvm-project/commit/cead4eceb01b935fae07bf4a7e91911b344d2fec The symbolizer is unusably slow with it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

aeubanks added a comment. `not` will set `LLVM_DISABLE_SYMBOLIZATION` if we use `not --crash` are these tests supposed to crash or gracefully fail? if they're supposed to crash then we should use `not --crash` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

ahatanak added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148851/new/ https://reviews.llvm.org/D148851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

ahatanak updated this revision to Diff 520861. ahatanak added a comment. Disable `llvm-symbolizer` individually. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148851/new/ https://reviews.llvm.org/D148851 Files:

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

ahatanak added a comment. In D148851#4328345 , @shafik wrote: > In D148851#4328084 , @dblaikie > wrote: > >> In D148851#4311266 , @ahatanak >> wrote: >> >>> Disable

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

shafik added a comment. In D148851#4328084 , @dblaikie wrote: > In D148851#4311266 , @ahatanak > wrote: > >> Disable llvm-symbolizer when running lit tests. > > This seems problematic though - when lit tests

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

dblaikie added a comment. In D148851#4311266 , @ahatanak wrote: > Disable llvm-symbolizer when running lit tests. This seems problematic though - when lit tests fail it's quite helpful to get a symbolized stack trace. Repository: rG LLVM Github

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

ahatanak updated this revision to Diff 518630. ahatanak added a comment. Enable llvm-symbolizer when running disable-crash-reports.test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148851/new/ https://reviews.llvm.org/D148851 Files:

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

ahatanak updated this revision to Diff 518610. ahatanak added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Disable llvm-symbolizer when running lit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

dblaikie added a comment. > I think we probably should add LLVM_DISABLE_SYMBOLIZATION=1 to the lit level, > not in individual tests. Though I'm not sure how to do that in a way that it doesn't apply to test that are genuinely failing, where a symbolized backtrace is helpful/important/exactly

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

dblaikie added a comment. I'm OK with this, though I wouldn't mind a more robust/general solution to this - especially all gunit death tests have this problem too - they crash and spend significant time symbolizing, I think? So it'd be great if we could find some way to run those with

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

MaskRay added a comment. In D148851#4285583 , @shafik wrote: > Do you know why these started timing out? I saw this locally the other day > but could not figure out the root cause. D86170 provides some information

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

shafik added a comment. Do you know why these started timing out? I saw this locally the other day but could not figure out the root cause. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148851/new/ https://reviews.llvm.org/D148851

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

ahatanak added a comment. These tests are all timing out after 600 seconds. https://green.lab.llvm.org/green/job/clang-stage1-RA/34005/#showFailuresLink Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148851/new/ https://reviews.llvm.org/D148851

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

ahatanak created this revision. ahatanak added reviewers: delcypher, MaskRay, dblaikie. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. These tests don't require invoking llvm-symbolizer. Repository: rG LLVM Github Monorepo