[PATCH] D148949: [dataflow] HTMLLogger - show the value of the current expr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb56b15ed719b: [dataflow] HTMLLogger - show the value of the current expr (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D148949: [dataflow] HTMLLogger - show the value of the current expr

mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp:96 +for (const auto& Prop : V.properties()) + JOS.attributeObject(Prop.first(), [&] { dump(*Prop.second); }); + sammccall wrote: > mboehme wrote: > > sammccall wro

[PATCH] D148949: [dataflow] HTMLLogger - show the value of the current expr

sammccall added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp:96 +for (const auto& Prop : V.properties()) + JOS.attributeObject(Prop.first(), [&] { dump(*Prop.second); }); + mboehme wrote: > sammccall wrote: > > mboehme wro

[PATCH] D148949: [dataflow] HTMLLogger - show the value of the current expr

sammccall updated this revision to Diff 516689. sammccall added a comment. display properties at the end of the kv list Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148949/new/ https://reviews.llvm.org/D148949 Files: clang/include/clang/Analysi

[PATCH] D148949: [dataflow] HTMLLogger - show the value of the current expr

mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp:96 +for (const auto& Prop : V.properties()) + JOS.attributeObject(Prop.first(), [&] { dump(*Prop.second); }); + sammccall wrote: > mboehme wrote: > > IIUC, this pl

[PATCH] D148949: [dataflow] HTMLLogger - show the value of the current expr

sammccall updated this revision to Diff 516395. sammccall added a comment. use p: and f: prefixes for properties/fields respectively (we can remove these again if too annoying) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148949/new/ https://revi

[PATCH] D148949: [dataflow] HTMLLogger - show the value of the current expr

sammccall updated this revision to Diff 516392. sammccall marked an inline comment as done. sammccall added a comment. fix bad cast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148949/new/ https://reviews.llvm.org/D148949 Files: clang/include/c

[PATCH] D148949: [dataflow] HTMLLogger - show the value of the current expr

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp:96 +for (const auto& Prop : V.properties()) + JOS.attributeObject(Prop.first(), [&] { dump(*Prop.second); }); + mboeh

[PATCH] D148949: [dataflow] HTMLLogger - show the value of the current expr

mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp:96 +for (const auto& Prop : V.properties()) + JOS.attributeObject(Prop.first(), [&] { dump(*Prop.second); }); + IIUC, this places properties on the current HTML el

[PATCH] D148949: [dataflow] HTMLLogger - show the value of the current expr

sammccall created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https