This revision was automatically updated to reflect the committed changes.
Closed by commit rG6ccb8061724f: [clang-tidy] Extract areStatementsIdentical
(authored by PiotrZSL).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148995/new/
https://reviews.
carlosgalvezp accepted this revision.
carlosgalvezp added a comment.
This revision is now accepted and ready to land.
> Separating the changes into two patches would only prolong this process and
> potentially delay the completion of this task.
I understand the concern, but in practice it's actu
PiotrZSL added a comment.
Thank you for your feedback regarding the code review. I understand that the
review includes the removal of 35 lines and the addition of 42 lines. However,
I would like to point out that the areStatementsIdentical function and the
other function in question are only ar
carlosgalvezp added a comment.
Thanks for the refactoring, great to remove some code duplication!
As a reviewer it's not possible for me to confidently review the functional
changes to `areStatementsIdentical`, since they don't show side by side as they
are in different files. Please perform th
PiotrZSL created this revision.
PiotrZSL added reviewers: njames93, carlosgalvezp.
Herald added a subscriber: xazax.hun.
Herald added a project: All.
PiotrZSL requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Move areStatementsIde
