This revision was automatically updated to reflect the committed changes.
Closed by commit rG80a21ea8006f: [clang][analyzer] Cleanup tests of
StdCLibraryFunctionsChecker (NFC) (authored by balazske).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D1491
steakhal accepted this revision.
steakhal added a comment.
This revision is now accepted and ready to land.
LGTM, premerge checks are green AFAICT. Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149158/new/
https://reviews.llvm.org/D149158
balazske updated this revision to Diff 521326.
balazske added a comment.
Change of some type definitions, using `restrict` again.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149158/new/
https://reviews.llvm.org/D149158
Files:
clang/test/Analys
steakhal added inline comments.
Comment at: clang/test/Analysis/Inputs/std-c-library-functions.h:1-2
+typedef typeof(sizeof(int)) size_t;
+typedef signed long ssize_t;
+typedef struct {
balazske wrote:
> steakhal wrote:
> > donat.nagy wrote:
> > > balazske wrote:
balazske added inline comments.
Comment at: clang/test/Analysis/Inputs/std-c-library-functions.h:1-2
+typedef typeof(sizeof(int)) size_t;
+typedef signed long ssize_t;
+typedef struct {
steakhal wrote:
> donat.nagy wrote:
> > balazske wrote:
> > > steakhal wrote:
steakhal added inline comments.
Comment at: clang/test/Analysis/Inputs/std-c-library-functions.h:1-2
+typedef typeof(sizeof(int)) size_t;
+typedef signed long ssize_t;
+typedef struct {
donat.nagy wrote:
> balazske wrote:
> > steakhal wrote:
> > > balazske wrote:
donat.nagy added inline comments.
Comment at: clang/test/Analysis/Inputs/std-c-library-functions.h:1-2
+typedef typeof(sizeof(int)) size_t;
+typedef signed long ssize_t;
+typedef struct {
balazske wrote:
> steakhal wrote:
> > balazske wrote:
> > > steakhal wrote:
balazske added inline comments.
Comment at: clang/test/Analysis/Inputs/std-c-library-functions.h:1-2
+typedef typeof(sizeof(int)) size_t;
+typedef signed long ssize_t;
+typedef struct {
steakhal wrote:
> balazske wrote:
> > steakhal wrote:
> > > `ssize_t`'s size
steakhal added inline comments.
Comment at: clang/test/Analysis/Inputs/std-c-library-functions.h:1-2
+typedef typeof(sizeof(int)) size_t;
+typedef signed long ssize_t;
+typedef struct {
balazske wrote:
> steakhal wrote:
> > `ssize_t`'s size should match the size
balazske marked an inline comment as done.
balazske added inline comments.
Comment at: clang/test/Analysis/Inputs/std-c-library-functions.h:1-2
+typedef typeof(sizeof(int)) size_t;
+typedef signed long ssize_t;
+typedef struct {
steakhal wrote:
> `ssize_t`'s size
balazske updated this revision to Diff 517196.
balazske added a comment.
using `__restrict` instead of `restrict`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149158/new/
https://reviews.llvm.org/D149158
Files:
clang/test/Analysis/Inputs/std-c-
steakhal added inline comments.
Comment at: clang/test/Analysis/Inputs/std-c-library-functions.h:1-2
+typedef typeof(sizeof(int)) size_t;
+typedef signed long ssize_t;
+typedef struct {
`ssize_t`'s size should match the size of `size_t`. In this implementation, i
balazske created this revision.
Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411,
dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet,
baloghadamsoftware, xazax.hun.
Herald added a reviewer: Szelethus.
Herald added a project: All.
balazske requested revie
13 matches
Mail list logo
