[PATCH] D149182: Remove -Wpacked false positive for non-pod types where the layout isn't directly changed

dblaikie added inline comments. Comment at: clang/docs/ReleaseNotes.rst:109-113 +Warnings + +- Address a false positive in ``-Wpacked`` when applied to a non-pod type using + Clang ABI >= 15 (fixes `#62353`_, +

[PATCH] D149182: Remove -Wpacked false positive for non-pod types where the layout isn't directly changed

dblaikie added inline comments. Comment at: clang/docs/ReleaseNotes.rst:109-113 +Warnings + +- Address a false positive in ``-Wpacked`` when applied to a non-pod type using + Clang ABI >= 15 (fixes `#62353`_, +

[PATCH] D149182: Remove -Wpacked false positive for non-pod types where the layout isn't directly changed

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. dblaikie marked an inline comment as done. Closed by commit rGa8b0c6fa28ac: Remove -Wpacked false positive for non-pod types where the layout isnt… (authored by

[PATCH] D149182: Remove -Wpacked false positive for non-pod types where the layout isn't directly changed

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit with the release notes. Thank you for the fix! Comment at: clang/docs/ReleaseNotes.rst:109-113 +Warnings + +- Address a false

[PATCH] D149182: Remove -Wpacked false positive for non-pod types where the layout isn't directly changed

dblaikie marked an inline comment as done. dblaikie added a comment. In D149182#4312202 , @aaron.ballman wrote: > Precommit CI found a valid issue (at least on Debian, the Windows failure > appears to be unrelated but it's really hard to tell from that

[PATCH] D149182: Remove -Wpacked false positive for non-pod types where the layout isn't directly changed

dblaikie updated this revision to Diff 519247. dblaikie added a comment. Describe condition in comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149182/new/ https://reviews.llvm.org/D149182 Files: clang/docs/ReleaseNotes.rst

[PATCH] D149182: Remove -Wpacked false positive for non-pod types where the layout isn't directly changed

dblaikie updated this revision to Diff 519245. dblaikie added a comment. Release note Restrict change to Clang ABI 16 and above (& test that condition) Fix AIX test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149182/new/

[PATCH] D149182: Remove -Wpacked false positive for non-pod types where the layout isn't directly changed

aaron.ballman added a comment. Precommit CI found a valid issue (at least on Debian, the Windows failure appears to be unrelated but it's really hard to tell from that output). Also, this should have a release note, right? Comment at:

[PATCH] D149182: Remove -Wpacked false positive for non-pod types where the layout isn't directly changed

dblaikie added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149182/new/ https://reviews.llvm.org/D149182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D149182: Remove -Wpacked false positive for non-pod types where the layout isn't directly changed

dblaikie created this revision. dblaikie added a reviewer: aaron.ballman. Herald added a project: All. dblaikie requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The packed attribute can still be useful in this case if the struct is then