xazax.hun closed this revision.
xazax.hun added a comment.
Committed in r254394.
http://reviews.llvm.org/D14919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D14919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
xazax.hun added a comment.
In http://reviews.llvm.org/D14919#297168, @seaneveson wrote:
> I was wondering what sort of source code causes the crash, but I do think it
> would be good to have a regression test.
It is possible to generate bug reports without associated declaration, altough
it i
seaneveson added a comment.
In http://reviews.llvm.org/D14919#296597, @o.gyorgy wrote:
> I did not create a test checker for the NormalizeLine error in the patch.
> Should I add a test checker for this?
I was wondering what sort of source code causes the crash, but I do think it
would be good
I did not create a test checker for the NormalizeLine error in the patch.
Should I add a test checker for this? Do you have any suggestions
where to put it if required?
GetEnclosingDeclContextSignature already checks for nullptr, this
should have been done in the NormalizeLine function also, but i
o.gyorgy added a subscriber: o.gyorgy.
o.gyorgy marked an inline comment as done.
o.gyorgy added a comment.
I did not create a test checker for the NormalizeLine error in the patch.
Should I add a test checker for this? Do you have any suggestions
where to put it if required?
GetEnclosingDeclCont
seaneveson added a subscriber: seaneveson.
seaneveson added a comment.
> If the Decl *D pointer is nullptr the NormalizeLine would crash while getting
> the LangOptions.
Do you have a reproducible test case for this?
http://reviews.llvm.org/D14919
__
o.gyorgy updated this revision to Diff 41024.
o.gyorgy added a comment.
Some small format changes. Based on the review.
http://reviews.llvm.org/D14919
Files:
include/clang/StaticAnalyzer/Core/IssueHash.h
lib/Basic/SourceManager.cpp
lib/StaticAnalyzer/Checkers/DebugCheckers.cpp
lib/Stati
xazax.hun added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/IssueHash.h:42
@@ -41,1 +41,3 @@
+ llvm::StringRef BugType, const Decl *D,
+ const LangOptions& LangOpts);
Please p
o.gyorgy updated this revision to Diff 40920.
o.gyorgy added a comment.
Regenerate patch with context and clang format HTMLDiagnostics.cpp.
http://reviews.llvm.org/D14919
Files:
include/clang/StaticAnalyzer/Core/IssueHash.h
lib/Basic/SourceManager.cpp
lib/StaticAnalyzer/Checkers/DebugChec
o.gyorgy created this revision.
o.gyorgy added reviewers: zaks.anna, xazax.hun, dcoughlin, jordan_rose.
o.gyorgy added a subscriber: cfe-commits.
Fixing IssueHash generation.
There were some problems with the current version.
If the Decl *D pointer is nullptr the NormalizeLine would crash while g
11 matches
Mail list logo
