This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG220e77a83af1: [clang][CodeGenPGO] Dont use an invalid
index when region counts disagree (authored by lanza).
Changed prior to commit:
smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.
Seems pretty reasonable to add a bounds check here. You should probably add a
comment explaining the reasoning though.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
lanza added a comment.
Actually, this still is consumed even without that flag being passed. Anybody
know the rational for not having at least an llvm major version check here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149504/new/
lanza created this revision.
lanza added a reviewer: bruno.
Herald added subscribers: wlei, wenlei, arphaman.
Herald added a project: All.
lanza requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
If we're using an old instrprof profile and
