[PATCH] D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf3dcd3ad992c: [clang-format] Correctly limit formatted ranges when specifying qualifier… (authored by cogilvie, committed by owenpan). Repository:

[PATCH] D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment

cogilvie added a comment. In D149643#4316128 , @MyDeveloperDay wrote: > Thanks for the patch...this tells me people are starting to use this feature > in anger!! i.e. your formatting via git-clang-format (which is brave!) ;-) > which means you have

[PATCH] D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment

cogilvie marked 2 inline comments as done. cogilvie added a comment. Fixed review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149643/new/ https://reviews.llvm.org/D149643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment

cogilvie updated this revision to Diff 519389. cogilvie marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149643/new/ https://reviews.llvm.org/D149643 Files: clang/lib/Format/QualifierAlignmentFixer.cpp clang/unittests/Format/QualifierFixerTest.cpp

[PATCH] D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment

owenpan added a comment. Please mark review comments as done after addressing them. Comment at: clang/unittests/Format/QualifierFixerTest.cpp:1356 + "template Foo const f();", + Style, std::vector(1, tooling::Range(0, 36))); +

[PATCH] D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment

MyDeveloperDay added a comment. Thanks for the patch...this tells me people are starting to use this feature in anger!! i.e. your formatting via git-clang-format (which is brave!) ;-) which means you have the code modifying features perhaps on my default... LGTM, if you will need someone to

[PATCH] D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment

cogilvie updated this revision to Diff 519008. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149643/new/ https://reviews.llvm.org/D149643 Files: clang/lib/Format/QualifierAlignmentFixer.cpp clang/unittests/Format/QualifierFixerTest.cpp Index:

[PATCH] D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment

cogilvie updated this revision to Diff 519007. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149643/new/ https://reviews.llvm.org/D149643 Files: clang/lib/Format/QualifierAlignmentFixer.cpp clang/unittests/Format/QualifierFixerTest.cpp Index:

[PATCH] D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/unittests/Format/QualifierFixerTest.cpp:1351 + + // Only the first line should be formatted the second should remain as is + EXPECT_EQ("template const Foo f();\n"