This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc0a36a157d97: [clang][Interp] Fix ignoring
CompoundLiteralExprs (authored by tbaeder).
Changed prior to commit:
https://reviews.llvm.org/D149837?v
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149837/new/
https://reviews.llvm.org/D149837
___
cfe-commits mailing lis
tbaeder updated this revision to Diff 520153.
tbaeder marked an inline comment as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149837/new/
https://reviews.llvm.org/D149837
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/test/AST/Interp/literals.cpp
Index: clang/test/AS
aaron.ballman added inline comments.
Comment at: clang/test/AST/Interp/literals.cpp:878
+(int){1};
+(int[]){1,2,3};
Can you also add a test like:
```
constexpr int oh_my(int x) {
(int){ x++ };
return x;
}
static_assert(oh_my(0) == 1);
```
and
```
co
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:537
+}
}
return true;
Obviously, this patch also fixes ignoring `InitListExpr`s.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llv
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://revi
