[PATCH] D149917: [lld][WebAssembly] Add --preserve-features flag

sbc100 added a comment. Updated to use `--keep-section`. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149917/new/ https://reviews.llvm.org/D149917 ___ cfe-commits mailing list

[PATCH] D149917: [lld][WebAssembly] Add --preserve-features flag

sbc100 updated this revision to Diff 557937. sbc100 added a comment. - rename flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149917/new/ https://reviews.llvm.org/D149917 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp

[PATCH] D149917: [lld][WebAssembly] Add --preserve-features flag

dschuff added a comment. or use `--keep-section` to match objcopy/strip? https://github.com/llvm/llvm-project/blob/main/llvm/test/tools/llvm-objcopy/wasm/basic-keep.test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149917/new/

[PATCH] D149917: [lld][WebAssembly] Add --preserve-features flag

dschuff added a comment. Yeah, I think that would work. Or maybe `--preserve-sections=sec1,sec2` since we might want to preserve multiple sections. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149917/new/ https://reviews.llvm.org/D149917

[PATCH] D149917: [lld][WebAssembly] Add --preserve-features flag

sbc100 added a comment. In D149917#4322367 , @dschuff wrote: > Do we want to make this any more general? In the future we might want to > preserve other sections, e.g. passing optimization or profiling info from > LLVM to Binaryen. Or maybe JSPI info?

[PATCH] D149917: [lld][WebAssembly] Add --preserve-features flag

dschuff added a comment. Do we want to make this any more general? In the future we might want to preserve other sections, e.g. passing optimization or profiling info from LLVM to Binaryen. Or maybe JSPI info? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149917: [lld][WebAssembly] Add --preserve-features flag

sbc100 added a comment. Still needs a test.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149917/new/ https://reviews.llvm.org/D149917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D149917: [lld][WebAssembly] Add --preserve-features flag

sbc100 created this revision. Herald added subscribers: pmatos, asb, wingo, ecnelises, sunfish, jgravelle-google, dschuff. Herald added a project: All. sbc100 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, aheejin. Herald added a project: clang. This flag