[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

MaskRay added a comment. I'll make `-munaligned-access` `TargetSpecific` (D151590 ) to report errors for unsupported targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149946/new/

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

MaskRay added a comment. > [1]: > https://github.com/torvalds/linux/blob/master/arch/loongarch/include/asm/cpu.h#L77 > [2]: > https://github.com/torvalds/linux/blob/master/arch/loongarch/kernel/proc.c#L75 `master` will point to different commits. It'd be better to use a specific commit for

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47601815ec3a: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses` (authored by SixWeining). Repository: rG LLVM Github

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

SixWeining updated this revision to Diff 529164. SixWeining added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149946/new/ https://reviews.llvm.org/D149946 Files: clang/include/clang/Driver/Options.td

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

xen0n accepted this revision. xen0n added a comment. This revision is now accepted and ready to land. I've thought about this a bit harder; it now seems better longer-term to enable unaligned accesses by default (making the UAL-less models the special case). But most importantly, there's new

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

xry111 added a comment. OTOH if the Linux kernel is expected to emulate UAL, -march=generic should be //allowed// to generate unaligned access instructions for Linux targets. Frankly I prefer this personally, But I'm not sure if it will be a good practice in general... Repository: rG LLVM

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

xry111 added a comment. In D149946#4324877 , @SixWeining wrote: > In D149946#4324803 , @xen0n wrote: > >> From a LoongArch developer's perspective, it may be better to only enable >> UAL for LA464 and other

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

SixWeining added a comment. In D149946#4324803 , @xen0n wrote: > From a LoongArch developer's perspective, it may be better to only enable UAL > for LA464 and other supporting models, instead of for the generic > `loongarch64` model too. This is

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

xen0n added a comment. From a LoongArch developer's perspective, it may be better to only enable UAL for LA464 and other supporting models, instead of for the generic `loongarch64` model too. This is because although all server- and desktop-class LoongArch models have UAL, the embedded-class

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

SixWeining added a comment. Thanks @rengolin and @peter.smith. I just added a new test to show options remain unused on a target that does not support them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149946/new/

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

SixWeining updated this revision to Diff 520014. SixWeining added a comment. Add a test to show related options remain unused on a target that does not support them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149946/new/

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

peter.smith added a comment. No objections for moving out m_arm_Features_Group or adding the alias. It looks like that is currently unused i.e. no driver filters out the m_arm_Features_Group. I can't comment on the LoongArch specific parts of the patch. I think you may want to note in the

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

rengolin added a reviewer: peter.smith. rengolin added a comment. Rationale and implementation make sense to me. I'll let this one sit so that other folks, including Arm, can have a look, too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

SixWeining added a comment. TODO: update llvm/clang release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149946/new/ https://reviews.llvm.org/D149946 ___ cfe-commits mailing list

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

SixWeining created this revision. SixWeining added reviewers: xen0n, xry111, MaskRay, rengolin, benshi001, wangleiat. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. SixWeining requested review of this revision. Herald added projects: clang, LLVM. Herald added