[PATCH] D150001: [clang] Fix initializer_list matching failures with modules

2023-05-09 Thread Alan Zhao via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1d35f04c6cb: [clang] Fix initializer_list matching failures with modules (authored by ayzhao). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D150001: [clang] Fix initializer_list matching failures with modules

2023-05-09 Thread Alan Zhao via Phabricator via cfe-commits
ayzhao updated this revision to Diff 520744. ayzhao added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150001/new/ https://reviews.llvm.org/D150001 Files: clang/include/clang/AST/DeclBase.h clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D150001: [clang] Fix initializer_list matching failures with modules

2023-05-08 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150001/new/ https://reviews.llvm.org/D150001 ___ cfe-commits mailing list

[PATCH] D150001: [clang] Fix initializer_list matching failures with modules

2023-05-08 Thread Alan Zhao via Phabricator via cfe-commits
ayzhao updated this revision to Diff 520429. ayzhao marked an inline comment as done. ayzhao added a comment. add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150001/new/ https://reviews.llvm.org/D150001 Files:

[PATCH] D150001: [clang] Fix initializer_list matching failures with modules

2023-05-08 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. Nice! Comment at: clang/lib/Sema/SemaDeclCXX.cpp:11570 getStdNamespace()->setImplicit(true); +Context.getTranslationUnitDecl()->addDecl(getStdNamespace()); +getStdNamespace()->clearIdentifierNamespace(); This could use an

[PATCH] D150001: [clang] Fix initializer_list matching failures with modules

2023-05-06 Thread Yingchi Long via Phabricator via cfe-commits
inclyc accepted this revision. inclyc added a comment. This revision is now accepted and ready to land. I think this fix is simple and straightforward and resolved the problem mentioned on GH. However, please wait for #clang-language-wg member's

[PATCH] D150001: [clang] Fix initializer_list matching failures with modules

2023-05-05 Thread Alan Zhao via Phabricator via cfe-commits
ayzhao created this revision. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, if a class with a defined public virtual destructor is declared before including and initializer_list is