[PATCH] D150038: [Clang] Improve compile times when forming a DeclRef outside of a capturing scope.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7579b25df78: [Clang] Improve compile times when forming a DeclRef outside of a capturing… (authored by cor3ntin). Changed prior to commit:

[PATCH] D150038: [Clang] Improve compile times when forming a DeclRef outside of a capturing scope.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Fantastic, that's some nice green in there. LGTM modulo nits, please add `NFC` to the patch summary when landing so folks know not to expect test coverage. Repository: rG

[PATCH] D150038: [Clang] Improve compile times when forming a DeclRef outside of a capturing scope.

cor3ntin added a comment. In D150038#4326576 , @aaron.ballman wrote: > In D150038#4326554 , @cor3ntin > wrote: > >> In D150038#4326549 , >> @aaron.ballman wrote: >>

[PATCH] D150038: [Clang] Improve compile times when forming a DeclRef outside of a capturing scope.

aaron.ballman added a comment. In D150038#4326554 , @cor3ntin wrote: > In D150038#4326549 , @aaron.ballman > wrote: > >> Do you have some performance measurement numbers for how much benefit we get >> from the

[PATCH] D150038: [Clang] Improve compile times when forming a DeclRef outside of a capturing scope.

cor3ntin added a comment. In D150038#4326549 , @aaron.ballman wrote: > Do you have some performance measurement numbers for how much benefit we get > from the changes? Not really. The PR that changed the scope of trailing return type had a 0.35%

[PATCH] D150038: [Clang] Improve compile times when forming a DeclRef outside of a capturing scope.

aaron.ballman added a comment. Do you have some performance measurement numbers for how much benefit we get from the changes? Comment at: clang/lib/Sema/SemaExpr.cpp:19195 + + // tryCaptureVariable is called ever ytime a DeclRef is formed, + // it can therefore have

[PATCH] D150038: [Clang] Improve compile times when forming a DeclRef outside of a capturing scope.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The logic of whether an entity needs to be captured has become quite complex and the recent changes in