[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

owenpan marked 2 inline comments as done. owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:6371-6380 + verifyFormat("#if FOO\n" + "int a = 1;\n" + "#else\n" + "int ab = 2;\n" + "#endif\n" +

[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

owenpan marked 2 inline comments as done. owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:6371-6380 + verifyFormat("#if FOO\n" + "int a = 1;\n" + "#else\n" + "int ab = 2;\n" + "#endif\n" +

[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:6371-6380 + verifyFormat("#if FOO\n" + "int a = 1;\n" + "#else\n" + "int ab = 2;\n" + "#endif\n" + "#ifdef BAR\n" +

[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4c87f8ccacc: [clang-format] Fix consecutive alignments in #else blocks (authored by owenpan). Changed prior to commit: https://reviews.llvm.org/D150057?vs=520137=520560#toc Repository: rG LLVM

[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:6394 + "#elif BAZ\n" + "bool ab = true;\n" + "#endif\n" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

owenpan added a comment. In D150057#4325350 , @HazardyKnusperkeks wrote: > I have to say, I don't understand it, but I believe you. Why is continuing, > when the token is finalized the right thing? See D150057#inline-1449546

[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:6371-6380 + verifyFormat("#if FOO\n" + "int a = 1;\n" + "#else\n" + "int ab = 2;\n" + "#endif\n" + "#ifdef BAR\n" +

[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. I have to say, I don't understand it, but I believe you. Why is continuing, when the token is finalized the right thing? Comment at: clang/unittests/Format/FormatTestComments.cpp:4319 /\ -/ +/

[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM. Well done! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150057/new/ https://reviews.llvm.org/D150057

[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTestComments.cpp:2762 // These comments should *not* be aligned - EXPECT_NE( // change for EQ when fixed + EXPECT_EQ( // change for EQ when fixed "#if FOO\n" rymiel wrote: >

[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

rymiel added inline comments. Comment at: clang/unittests/Format/FormatTestComments.cpp:2762 // These comments should *not* be aligned - EXPECT_NE( // change for EQ when fixed + EXPECT_EQ( // change for EQ when fixed "#if FOO\n" Should probably get

[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

owenpan created this revision. owenpan added a reviewer: mitchell-stellar. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Since 3.8 or earlier,