[PATCH] D150108: [clang] Evaluate non-type default template argument when it is required

2023-05-09 Thread Mariya Podchishchaeva via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG74fd474eea53: [clang] Evaluate non-type default template argument when it is required (authored by Fznamznon). Changed prior to commit: https://reviews.llvm.org/D150108?vs=520325=520622#toc

[PATCH] D150108: [clang] Evaluate non-type default template argument when it is required

2023-05-08 Thread Mariya Podchishchaeva via Phabricator via cfe-commits
Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:1614 -TemplateArgument SugaredConverted, CanonicalConverted; -ExprResult DefaultRes = CheckTemplateArgument( shafik wrote: > Out of curiosity where is the template argument

[PATCH] D150108: [clang] Evaluate non-type default template argument when it is required

2023-05-08 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:1614 -TemplateArgument SugaredConverted, CanonicalConverted; -ExprResult DefaultRes = CheckTemplateArgument( Out of curiosity where is the template argument being checked now and

[PATCH] D150108: [clang] Evaluate non-type default template argument when it is required

2023-05-08 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM. I love it when remove it code fixes a bug! Thanks for the PR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150108/new/

[PATCH] D150108: [clang] Evaluate non-type default template argument when it is required

2023-05-08 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added inline comments. Comment at: clang/docs/ReleaseNotes.rst:375 +- A default argument for a non-type template parameter is evaluated and checked + at the point where is is required. This fixes: + (`#62224 `_) and

[PATCH] D150108: [clang] Evaluate non-type default template argument when it is required

2023-05-08 Thread Mariya Podchishchaeva via Phabricator via cfe-commits
Fznamznon created this revision. Herald added a subscriber: arphaman. Herald added a reviewer: shafik. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this change a default template argument