This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
probinson marked an inline comment as done.
Closed by commit rGd8291908ef49: [Headers][doc] Add add/sub/mul intrinsic
descriptions to avx2intrin.h (authored by
probinson marked an inline comment as done.
probinson added inline comments.
Comment at: clang/lib/Headers/avx2intrin.h:412
+///vectors of [16 x i16] and returns the lower 16 bits of each difference
+///in an element of the [16 x i16] result (overflow is ignored).
+///
pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.
LGTM except for a possible typo.
Comment at: clang/lib/Headers/avx2intrin.h:412
+///vectors of [16 x i16] and returns the lower 16 bits of each difference
+///in
probinson added inline comments.
Comment at: clang/lib/Headers/avx2intrin.h:456
+/// j := i*128
+/// result[j+31:j] := __a[j+63:j+32] - __a[j+31:j]
+/// result[j+63:j+32] := __a[j+127:j+96] - __a[j+95:j+64]
craig.topper wrote:
> Intel intrinsics guide says
probinson updated this revision to Diff 525632.
probinson added a comment.
Correct order of horizontal operands
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150114/new/
https://reviews.llvm.org/D150114
Files:
clang/lib/Headers/avx2intrin.h
Index: clang/lib/Headers/avx2intrin.h
craig.topper added inline comments.
Comment at: clang/lib/Headers/avx2intrin.h:456
+/// j := i*128
+/// result[j+31:j] := __a[j+63:j+32] - __a[j+31:j]
+/// result[j+63:j+32] := __a[j+127:j+96] - __a[j+95:j+64]
Intel intrinsics guide says
```
dst[31:0] :=
probinson updated this revision to Diff 524786.
probinson added a comment.
Address review comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150114/new/
https://reviews.llvm.org/D150114
Files:
clang/lib/Headers/avx2intrin.h
Index: clang/lib/Headers/avx2intrin.h
probinson added inline comments.
Comment at: clang/lib/Headers/avx2intrin.h:156
+///A 256-bit vector containing one of the source operands.
+/// \returns A 256-bit vector containing the sums.
static __inline__ __m256i __DEFAULT_FN_ATTRS256
craig.topper
pengfei added inline comments.
Comment at: clang/lib/Headers/avx2intrin.h:1043
+///corresponding byte of the 256-bit integer vector result (overflow is
+///ignored). For each byte, computes result = __a - __b .
+///
It better to move it to
craig.topper added inline comments.
Comment at: clang/lib/Headers/avx2intrin.h:156
+///A 256-bit vector containing one of the source operands.
+/// \returns A 256-bit vector containing the sums.
static __inline__ __m256i __DEFAULT_FN_ATTRS256
Why do some
RKSimon added a comment.
@pengfei Any objections?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150114/new/
https://reviews.llvm.org/D150114
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
probinson created this revision.
probinson added reviewers: pengfei, RKSimon, goldstein.w.n, craig.topper.
Herald added a project: All.
probinson requested review of this revision.
https://reviews.llvm.org/D150114
Files:
clang/lib/Headers/avx2intrin.h
Index: clang/lib/Headers/avx2intrin.h
12 matches
Mail list logo
