[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rG245549c57517: [NFC][CLANG] Fix Static Code Analysis Concerns (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150140/new/

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna added a comment. Thank you everyone for comments and reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150140/new/ https://reviews.llvm.org/D150140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna marked an inline comment as done. Manna added a comment. In D150140#4333552 , @tahonermann wrote: > Looks good to me! Thank you @tahonermann for reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150140/new/

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks good to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150140/new/ https://reviews.llvm.org/D150140 ___ cfe-commits

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna marked an inline comment as done. Manna added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:302 unsigned Shift = llvm::countr_zero(Mask); + assert(Shift >= 64 && "Shift is out of encodable range"); return (V << Shift) & Mask;

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna updated this revision to Diff 521089. Manna added a comment. Fix Coverity complain about shift overflow issue CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150140/new/ https://reviews.llvm.org/D150140 Files: clang/utils/TableGen/SveEmitter.cpp Index:

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

tahonermann added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:302 unsigned Shift = llvm::countr_zero(Mask); + assert(Shift >= 64 && "Shift is out of encodable range"); return (V << Shift) & Mask; Manna wrote: > sdesmalen

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna updated this revision to Diff 520693. Manna marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150140/new/ https://reviews.llvm.org/D150140 Files: clang/utils/TableGen/SveEmitter.cpp Index: clang/utils/TableGen/SveEmitter.cpp

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna marked 4 inline comments as done. Manna added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:302 unsigned Shift = llvm::countr_zero(Mask); + assert(Shift >= 64 && "Shift is out of encodable range"); return (V << Shift) & Mask;

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna updated this revision to Diff 520681. Manna edited the summary of this revision. Manna added a comment. Thank you for reviews and comments @erichkeane and @sdesmalen! I have updated patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150140/new/

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

sdesmalen added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:302 unsigned Shift = llvm::countr_zero(Mask); + assert(Shift >= 64 && "Shift is out of encodable range"); return (V << Shift) & Mask; erichkeane wrote: >

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

erichkeane added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:302 unsigned Shift = llvm::countr_zero(Mask); + assert(Shift >= 64 && "Shift is out of encodable range"); return (V << Shift) & Mask; sdesmalen wrote: >

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

sdesmalen added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:302 unsigned Shift = llvm::countr_zero(Mask); + assert(Shift >= 64 && "Shift is out of encodable range"); return (V << Shift) & Mask; erichkeane wrote: >

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

erichkeane added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:302 unsigned Shift = llvm::countr_zero(Mask); + assert(Shift >= 64 && "Shift is out of encodable range"); return (V << Shift) & Mask; Shouldn't this be:

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna created this revision. Manna added reviewers: erichkeane, tahonermann. Herald added a subscriber: ctetreau. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Reported by Static Analyzer Tool, Coverity: Bad bit shift operation The