VitaNuo added inline comments.
Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:457
+ // Don't keep track for non-identifier names.
+ if (auto *II = Decl->getIdentifier()) {
+return addUsage(RenamerClangTidyCheck::NamingCheckId(Decl->getLocation(),
-
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb36a2e7828be: [tidy][IdentifierNaming] Fix crashes on
non-identifiers (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE L
kadircet updated this revision to Diff 520648.
kadircet marked 3 inline comments as done.
kadircet added a comment.
Merge with existing tests
Perform check earlier
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150187/new/
https://reviews.llvm.org/D
PiotrZSL added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-nocrash.cpp:3-5
+struct Foo {
+ operator bool();
+};
PiotrZSL wrote:
> i would merge this with some existing test file...
yep, tests fails due t
PiotrZSL accepted this revision.
PiotrZSL added a comment.
This revision is now accepted and ready to land.
LGTM, fell free to deliver (to quickly fix crash).
Any improvements could be done later.
Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:457
+ /
kadircet created this revision.
kadircet added a reviewer: VitaNuo.
Herald added subscribers: PiotrZSL, carlosgalvezp.
Herald added a reviewer: njames93.
Herald added a project: All.
kadircet requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cf
