[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

MaskRay added a comment. In D150282#4341060 , @Jake-Egan wrote: > Hi, this fails on AIX. It looks like it still produces the > `/tmp/lit-tmp-*/[ab]-*.json` format. Can you take a look please? > >

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

Jake-Egan added a comment. Hi, this fails on AIX. It looks like it still produces the `/tmp/lit-tmp-*/[ab]-*.json` format. Can you take a look please? https://lab.llvm.org/buildbot/#/builders/214/builds/7429/steps/6/logs/FAIL__Clang__ftime-trace_cpp Repository: rG LLVM Github Monorepo

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

thakis added a comment. Apologies for the noise, looks like my win bot hasn't built in a while. Looks like this is already fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150282/new/ https://reviews.llvm.org/D150282

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

thakis added a comment. This breaks tests on windows: http://45.33.8.238/win/78516/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150282/new/

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

MaskRay added inline comments. Comment at: clang/test/Driver/ftime-trace.cpp:54 +// RUN: %clang -### -ftime-trace=e -ftime-trace-granularity=0 d/a.cpp d/b.c -o f/x -dumpdir f/ 2>&1 | FileCheck %s --check-prefix=LINK3 +// LINK3: -cc1{{.*}} "-ftime-trace=e/a-{{[^.]*}}.json"

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

dyung added inline comments. Comment at: clang/test/Driver/ftime-trace.cpp:54 +// RUN: %clang -### -ftime-trace=e -ftime-trace-granularity=0 d/a.cpp d/b.c -o f/x -dumpdir f/ 2>&1 | FileCheck %s --check-prefix=LINK3 +// LINK3: -cc1{{.*}} "-ftime-trace=e/a-{{[^.]*}}.json"

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG49b87b05726b: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir (authored by MaskRay). Repository: rG LLVM Github Monorepo

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

Maetveis accepted this revision. Maetveis added a comment. This revision is now accepted and ready to land. I don't see anything in here that would block later extension for supporting offloading, so LGTM from my POV. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

scott.linder added inline comments. Comment at: clang/include/clang/Driver/Compilation.h:279 + void addTimeTraceFile(const char *Name, const JobAction *JA) { +TimeTraceFiles[JA] = Name; + } MaskRay wrote: > scott.linder wrote: > > If this is overriding

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

MaskRay added a comment. In D150282#4335568 , @scott.linder wrote: > Does GCC have the same `-ftime-trace=` option? It seems like it doesn't, as > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92396 is still open? You found it! I am trying to collect

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

MaskRay updated this revision to Diff 521427. MaskRay marked an inline comment as done. MaskRay edited the summary of this revision. MaskRay added a comment. add an assert to addTimeTraceFile. improve a -dumpdir test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

scott.linder added a comment. Does GCC have the same `-ftime-trace=` option? It seems like it doesn't, as https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92396 is still open? If so, I am happy with unifying more of the dump/aux handling, and I imagine when/if GCC adds the option it will behave

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

MaskRay updated this revision to Diff 521379. MaskRay marked an inline comment as done. MaskRay edited the summary of this revision. MaskRay added a comment. Add a warning test. Report -Wunused-command-line-argument warning for -ftime-trace-granularity=0 if unused as well. Repository: rG

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

MaskRay marked an inline comment as done. MaskRay added a comment. In D150282#4334927 , @Maetveis wrote: > LGTM, but I don't feel like I have the experience to "formally" approve. I > left a nice-to have suggestion too, but feel free to ignore, if you

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

Maetveis added a comment. LGTM, but I don't feel like I have the experience to "formally" approve. I left a nice-to have suggestion too, but feel free to ignore, if you feel its out of scope. Comment at: clang/lib/Driver/Driver.cpp:5514 BaseInput); +

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

MaskRay created this revision. MaskRay added reviewers: clang, jamieschmeiser, Whitney, Maetveis, dblaikie, scott.linder. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Inspired by D133662