[PATCH] D150364: [clang][Interp] Add 'Unsupported' opcode and use it for throw stmts

tbaeder updated this revision to Diff 521568. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150364/new/ https://reviews.llvm.org/D150364 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/In

[PATCH] D150364: [clang][Interp] Add 'Unsupported' opcode and use it for throw stmts

tbaeder added a comment. In D150364#4335282 , @aaron.ballman wrote: > In D150364#4335261 , @tbaeder wrote: > >> In D150364#4335221 , >> @aaron.ballman wrote: >> >>> "Uns

[PATCH] D150364: [clang][Interp] Add 'Unsupported' opcode and use it for throw stmts

aaron.ballman added a comment. In D150364#4335261 , @tbaeder wrote: > In D150364#4335221 , @aaron.ballman > wrote: > >> "Unsupported" is a bit of a loaded term -- it could mean "this operation is >> not supporte

[PATCH] D150364: [clang][Interp] Add 'Unsupported' opcode and use it for throw stmts

tbaeder updated this revision to Diff 521346. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150364/new/ https://reviews.llvm.org/D150364 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/I

[PATCH] D150364: [clang][Interp] Add 'Unsupported' opcode and use it for throw stmts

tbaeder added a comment. In D150364#4335221 , @aaron.ballman wrote: > "Unsupported" is a bit of a loaded term -- it could mean "this operation is > not supported, YET" or it could mean "this operation is not and will not be > supported, EVER". Perhaps

[PATCH] D150364: [clang][Interp] Add 'Unsupported' opcode and use it for throw stmts

aaron.ballman added a comment. "Unsupported" is a bit of a loaded term -- it could mean "this operation is not supported, YET" or it could mean "this operation is not and will not be supported, EVER". Perhaps something more like "InvalidInConstantExpr" would be more descriptive?

[PATCH] D150364: [clang][Interp] Add 'Unsupported' opcode and use it for throw stmts

erichkeane added a comment. I've unfortunately not caught up enough to comment on the approach, but 'inline assembly' has the same restriction, so you might find `MsAsmStmt` and `GCCAsmStmt` to be equally as easy 'wins'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D150364: [clang][Interp] Add 'Unsupported' opcode and use it for throw stmts

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As discussed the other day. This fixes the diagnost