[PATCH] D150520: [clang] Convert a few tests to opaque pointers

2023-05-15 Thread Amy Kwan via Phabricator via cfe-commits
amyk added a comment. In D150520#4342943 , @barannikov88 wrote: > In D150520#4342429 , @amyk wrote: > >> Hi, I just wanted to give a heads up that it appears that this patch is >> causing failures on some of the

[PATCH] D150520: [clang] Convert a few tests to opaque pointers

2023-05-15 Thread Sergei Barannikov via Phabricator via cfe-commits
barannikov88 added a comment. In D150520#4342429 , @amyk wrote: > Hi, I just wanted to give a heads up that it appears that this patch is > causing failures on some of the PPC buildbots. > In particular, the `const-str-array-decay.cl` appears to be faili

[PATCH] D150520: [clang] Convert a few tests to opaque pointers

2023-05-15 Thread Sergei Barannikov via Phabricator via cfe-commits
barannikov88 added a comment. In D150520#4342429 , @amyk wrote: > Hi, I just wanted to give a heads up that it appears that this patch is > causing failures on some of the PPC buildbots. > In particular, the `const-str-array-decay.cl` appears to be faili

[PATCH] D150520: [clang] Convert a few tests to opaque pointers

2023-05-15 Thread Amy Kwan via Phabricator via cfe-commits
amyk added a comment. Hi, I just wanted to give a heads up that it appears that this patch is causing failures on some of the PPC buildbots. In particular, the `const-str-array-decay.cl` appears to be failing. The failing build can be seen in: https://lab.llvm.org/buildbot/#/builders/36/builds/

[PATCH] D150520: [clang] Convert a few tests to opaque pointers

2023-05-14 Thread Sergei Barannikov via Phabricator via cfe-commits
barannikov88 added a comment. Thanks. These were the lasts tests in these directories. The only one remaining is `clang/test/CodeGenOpenCL/opaque-ptr-spirv.cl`, I don't know what to do with it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150520/

[PATCH] D150520: [clang] Convert a few tests to opaque pointers

2023-05-14 Thread Nikita Popov via Phabricator via cfe-commits
nikic accepted this revision. nikic added a comment. Still LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150520/new/ https://reviews.llvm.org/D150520 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D150520: [clang] Convert a few tests to opaque pointers

2023-05-14 Thread Sergei Barannikov via Phabricator via cfe-commits
barannikov88 added a comment. @nikic I converted a few more tests after approved the changes. Please take a look once more, or let me know if I should revert to the previous revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150520/new/ https

[PATCH] D150520: [clang] Convert a few tests to opaque pointers

2023-05-14 Thread Nikita Popov via Phabricator via cfe-commits
nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150520/new/ https://reviews.llvm.org/D150520 ___ c

[PATCH] D150520: [clang] Convert a few tests to opaque pointers

2023-05-14 Thread Sergei Barannikov via Phabricator via cfe-commits
barannikov88 created this revision. Herald added subscribers: kerbowa, jvesely. Herald added a project: All. barannikov88 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D15052