This revision was automatically updated to reflect the committed changes.
Closed by commit rG008cb29f87f3: [clangd] Renaming: Treat member functions like
other functions (authored by ckandeler).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150685/ne
ckandeler updated this revision to Diff 524214.
ckandeler added a comment.
Fixed clang-format complaints.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150685/new/
https://reviews.llvm.org/D150685
Files:
clang-tools-extra/clangd/refactor/Rename.
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
nice, thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150685/new/
https://reviews.llvm.org/D150685
___
ckandeler updated this revision to Diff 524206.
ckandeler added a comment.
Formatting glitch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150685/new/
https://reviews.llvm.org/D150685
Files:
clang-tools-extra/clangd/refactor/Rename.cpp
clang-
ckandeler updated this revision to Diff 524203.
ckandeler added a comment.
Added test cases.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150685/new/
https://reviews.llvm.org/D150685
Files:
clang-tools-extra/clangd/refactor/Rename.cpp
clang-t
hokein added inline comments.
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:519
+if (RenameDecl.getKind() != Decl::Function &&
+RenameDecl.getKind() != Decl::CXXMethod) {
if (auto *Conflict = lookupSiblingWithName(ASTCtx, RenameDecl, NewName))
--
ckandeler added inline comments.
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:519
+if (RenameDecl.getKind() != Decl::Function &&
+RenameDecl.getKind() != Decl::CXXMethod) {
if (auto *Conflict = lookupSiblingWithName(ASTCtx, RenameDecl, NewName))
---
hokein added inline comments.
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:519
+if (RenameDecl.getKind() != Decl::Function &&
+RenameDecl.getKind() != Decl::CXXMethod) {
if (auto *Conflict = lookupSiblingWithName(ASTCtx, RenameDecl, NewName))
--
ckandeler created this revision.
ckandeler added a reviewer: hokein.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
ckandeler requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
...
