[PATCH] D150803: [WebAssembly] Support `annotate` clang attributes for marking functions.

MaskRay added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:568 + // Group all the custom attributes by name. + StringMap> CustomSections; + const ConstantArray *CA = cast(V->getOperand(0)); "StringMap iteration order, howe

[PATCH] D150803: [WebAssembly] Support `annotate` clang attributes for marking functions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG220fe00a7c0f: [WebAssembly] Support `annotate` clang attributes for marking functions. (authored by brendandahl, committed by dschuff). Repository:

[PATCH] D150803: [WebAssembly] Support `annotate` clang attributes for marking functions.

brendandahl updated this revision to Diff 539191. brendandahl added a comment. Rebase on main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150803/new/ https://reviews.llvm.org/D150803 Files: lld/test/wasm/func-attr-tombstone.s lld/test/wasm/

[PATCH] D150803: [WebAssembly] Support `annotate` clang attributes for marking functions.

sbc100 accepted this revision. sbc100 added a comment. lgtm. Can you update the change description now that we decided to not support values? (Ironically I think have a use for values in pipeline now) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D150803: [WebAssembly] Support `annotate` clang attributes for marking functions.

aaron.ballman resigned from this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D150803#4454188 , @sbc100 wrote: > In D150803#4454164 , @brendandahl > wrote: > >> In

[PATCH] D150803: [WebAssembly] Support `annotate` clang attributes for marking functions.

brendandahl marked an inline comment as not done. brendandahl added inline comments. Comment at: llvm/test/MC/WebAssembly/func-attr.s:21 +# CHECK-OBJ-NEXT: Offset: 0x0 +# CHECK-OBJ-NEXT: Name:func_attr.custom0 sbc100 wrote: > Sho

[PATCH] D150803: [WebAssembly] Support `annotate` clang attributes for marking functions.

brendandahl updated this revision to Diff 535187. brendandahl added a comment. Remove annotate arguments. Change name from func_attr to llvm.func_attr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150803/new/ https://reviews.llvm.org/D150803 File

[PATCH] D150803: [WebAssembly] Support `annotate` clang attributes for marking functions.

sbc100 added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:585-598 +// The fifth field is an optional pointer to the arguments. Append each +// argument to the name separated by a '.'. +auto *ArgsVar = dyn_cast(CS->getOperand(4)->

[PATCH] D150803: [WebAssembly] Support `annotate` clang attributes for marking functions.

brendandahl added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:585-598 +// The fifth field is an optional pointer to the arguments. Append each +// argument to the name separated by a '.'. +auto *ArgsVar = dyn_cast(CS->getOperand