tbaeder updated this revision to Diff 527766.
tbaeder added a comment.
@cor3ntin I added changes to the two brackets tests in `test/Parser/`. They
look like an improvement to me, but maybe there's something I'm missing, so
please have a quick look.
CHANGES SINCE LAST ACTION
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGfc1262bd58ac: [clang][Diagnostics] Split source ranges into
line ranges before... (authored by tbaeder).
Changed prior to commit:
cor3ntin accepted this revision.
cor3ntin added a comment.
This revision is now accepted and ready to land.
Looks good to me too!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151215/new/
https://reviews.llvm.org/D151215
aaron.ballman added reviewers: tahonermann, cor3ntin.
aaron.ballman added subscribers: cor3ntin, tahonermann.
aaron.ballman added a comment.
This looks correct to me, but because it involves things like characters,
lines, and output, I'd appreciate if @tahonermann or @cor3ntin could do the
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, cjdb, clang.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
... emitting them.
This makes later code easier to understand,
