This revision was automatically updated to reflect the committed changes.
shafik marked an inline comment as done.
Closed by commit rG2a23de01e515: [Clang] Switch from TransformExpr to
TransformInitializer in places we need to… (authored by shafik).
Herald added a project: clang.
Repository:
rG
shafik marked 2 inline comments as done.
shafik added inline comments.
Comment at: clang/test/CodeGenCXX/gh62818.cpp:1
+// RUN: %clang_cc1 -no-opaque-pointers -std=c++17 -emit-llvm -triple
x86_64-linux-gnu -o - %s | FileCheck %s
+
Fznamznon wrote:
> Why no opaqu
shafik updated this revision to Diff 525385.
shafik added a comment.
- Update test
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151235/new/
https://reviews.llvm.org/D151235
Files:
clang/lib/Sema/TreeTransform.h
clang/test/Analysis/missing-bind-temporary.cpp
clang/test/CodeGenCXX
Fznamznon added inline comments.
Comment at: clang/test/CodeGenCXX/gh62818.cpp:1
+// RUN: %clang_cc1 -no-opaque-pointers -std=c++17 -emit-llvm -triple
x86_64-linux-gnu -o - %s | FileCheck %s
+
Why no opaque pointers? AFAIK since LLVM 17 typed pointers are not su
shafik updated this revision to Diff 525248.
shafik added a comment.
- Update test gh62818.cpp to be more precise
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151235/new/
https://reviews.llvm.org/D151235
Files:
clang/lib/Sema/TreeTransform.h
clang/test/Analysis/missing-bind-tempor
erichkeane added a comment.
Change looks good, test is overly specific IMO.
Comment at: clang/test/CodeGenCXX/gh62818.cpp:27
+ // CHECK: %[[ASSIGN:.+]] = call noundef nonnull align 1 dereferenceable(1)
%struct.A* @_ZNR1AaSES_(%struct.A* noundef nonnull align 1 dereferenceable
shafik added a subscriber: NoQ.
shafik added inline comments.
Comment at: clang/test/Analysis/missing-bind-temporary.cpp:10
namespace variant_0 {
-// This variant of the code works correctly. Function foo() is not a template
-// function. Note that there are two destructors with
shafik created this revision.
shafik added reviewers: rsmith, aaron.ballman, erichkeane.
Herald added a project: All.
shafik requested review of this revision.
In some cases we are using `TransformExpr` instead of `TransformInitializer`,
this results in `ExprWithCleanups` being dropped and we are
